Open Bug 1311691 Opened 8 years ago Updated 4 years ago

Clean up uses of |_selectionDetails/telemetrySearchDetails | in autocomplete

Categories

(Firefox :: Search, task, P3)

Product:
Firefox
Component:
Search
Type:
task

Tracking

()

People

(Reporter: Dexter, Unassigned)

References

Details

(Whiteboard: [fxsearch][search-telemetry-backlog]) 

From bug 1303333 comment 16:

> The entire _selectionDetails/telemetrySearchDetails stuff in autocomplete looks hackish to me, I'm not sure why search needs autocomplete to save this info, rather than overriding "handleEnter" and storing this info locally. The original changesets introducing this doesn't make sense to me.
> I also don't know why part of the telemetry collection is in handleSearchCommandWhere and part is in doSearch, rather than being well collected together in a method.

We should investigate why we're using _selectionDetails/telemetrySearchDetails this way instead of overriding handleEnter and eventually clean up the code, if needed.
Blocks: 1303333
Priority: -- → P3
Whiteboard: [fxsearch]
Mass wontfix for bugs affecting firefox 52.
status-firefox52: affected → wontfix
Whiteboard: [fxsearch] → [fxsearch][search-telemetry-backlog]
Severity: normal → N/A
Type: defect → task
status-firefox52: wontfix → ---
You need to log in before you can comment on or make changes to this bug.