1311723 - Missing "mozinfo.json" after setting up an interactive loaner

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

Stas ran into a task that was failing to run mochitest on a one-click-loaner because it was missing mozinfo data. After looking at the task there was no "mozinfo.json" file under:
/home/worker/workspace/build/tests

This file should normally be packaged in the tests.zip, looks like something changed to regress this.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1311723 - Fix missing mozinfo.json when running interactive loaners,

Review commit: https://reviewboard.mozilla.org/r/87636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87636/

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1311723 - Fix wrong binary_path in desktop_unittest.py configs,

Review commit: https://reviewboard.mozilla.org/r/87638/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87638/

Comment 3

[Andrew Halberstadt [:ahal]]

I can't figure out what regressed this, and now I'm questioning how this ever worked in the first place (though it definitely did)... Anyway, these two patches get things working again for me. I think stas was still having problems with the mochitest harness finding his test, but I think it's best to file a new bug for that if it is still a problem after this.

Comment 4

[Armen [:armenzg]]

Comment on attachment 8803330 [details]
Bug 1311723 - Fix wrong binary_path in desktop_unittest.py configs,

https://reviewboard.mozilla.org/r/87638/#review86600

Comment 5

[Staś Małolepszy :stas]

Thanks for looking into this, Andrew!  I'll be happy to test running mochitests in the loaner once this lands and will file a new bug if the problem persists.

Comment 6

[Armen [:armenzg]]

Comment on attachment 8803329 [details]
Bug 1311723 - Fix missing mozinfo.json when running interactive loaners,

https://reviewboard.mozilla.org/r/87636/#review86598

What is the purpose of mozinfo.json? I don't really know the implications of adding this file to the mix.

Comment 7

[Andrew Halberstadt [:ahal]]

Comment on attachment 8803329 [details]
Bug 1311723 - Fix missing mozinfo.json when running interactive loaners,

https://reviewboard.mozilla.org/r/87636/#review86598

It's needed to filter the manifests among other things. I'm not really sure how the real automation jobs are getting it, but they must be otherwise everything would fail.

Comment 8

[(not currently active) Ted Mielczarek]

Every test package packages its own copy of mozinfo.json currently (kinda dumb):
https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/action/test_archive.py

...and each harness just looks for it next to the main harness script (or any parent dir):
https://dxr.mozilla.org/mozilla-central/rev/f0f1aaf051d6798e1e73d1feee07ca847333167a/testing/mochitest/runtests.py#819

We could drop that for harnesses when we get them running from the source checkout.

Assuming your interactive loaner script is unpacking the mochitest.zip as usual I would expect there to be a mozinfo.json under `tests/mochitest`. However! If you're running the runtests.py script from inside the source checkout instead of the test package that would definitely break.

Comment 9

[Andrew Halberstadt [:ahal]]

Oh right! I forgot it was under tests/mochitest and not the root of the package.. And here's why it's failing:
https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/mach_test_package_commands.py#64

That should just be 'here' instead of 'dirname(here)'. I'm still confused about how this was working before though. I'll get a new patch up instead of the old one.

Comment 10

[(not currently active) Ted Mielczarek]

You added that code in bug 1300163, so I assume that's what broke it :)
https://hg.mozilla.org/mozilla-central/rev/dd6f0732c260#l1.59

Comment 11

[Andrew Halberstadt [:ahal]]

Well that was when I last tested it and I'm pretty sure it was working.. but I must of tested differently or mis-remembered something.

Comment 12

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1311723 - Look for mozinfo.json in the correct place when running interactive loaners,

Review commit: https://reviewboard.mozilla.org/r/87738/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87738/

Comment 13

[Andrew Halberstadt [:ahal]]

Comment on attachment 8803330 [details]
Bug 1311723 - Fix wrong binary_path in desktop_unittest.py configs,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87638/diff/1-2/

Comment 14

[Armen [:armenzg]]

Comment on attachment 8803506 [details]
Bug 1311723 - Look for mozinfo.json in the correct place when running interactive loaners,

https://reviewboard.mozilla.org/r/87738/#review86724

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e9509be9108
Fix wrong binary_path in desktop_unittest.py configs, r=armenzg
https://hg.mozilla.org/integration/autoland/rev/85832226cbd7
Look for mozinfo.json in the correct place when running interactive loaners, r=armenzg

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e9509be9108
https://hg.mozilla.org/mozilla-central/rev/85832226cbd7