1311732 - ubuntu sending bad systemaddon update urls

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect, P3)

Description

[[e-mail] (:bhearsum)]

I happened to notice that Ubuntu's SystemAddon update URLs are a bit odd. They look like:
https://aus5.mozilla.org/update/3/SystemAddons/49.0/20160920074044/Linux_x86_64-gcc3/null/release-cck- âubuntuâ/Linux 4.4.0-45-generic (GTK 3.18.9,libpulse 8.0.0)/canonical/1.0/update.xml

I think there's a couple of issues with them:
1) The %LOCALE% section is set to "null". This probably isn't causing exceptions, but it's weird/wrong.
2) The channel contains odd unicode characters instead of a real channel.

Not having the channel properly means we're not shipping SystemAddons to Ubuntu users. The locale thing probably isn't actively harmful, but still useful to fix.

Comment 1

[Chris Coulson]

I'm travelling at the moment, but I'll try to make some time to take a look at this tomorrow

Comment 2

[:shell escalante]

thanks Chris - we'll wait to see what you find and check back next week.

Comment 3

[Chris Coulson]

Sorry for the delay - I'm looking at this right now.

The "null" in the %LOCALE% selection is because UpdateUtils.formatUpdateURL relies on the presence of update.locale in the omni.ja. This doesn't exist in our build because we build with --disable-updater.

In any case, we don't produce localized builds of Firefox (they're localized with language packs), so although adding update.locale to our build would get rid of the "null", it would result in it being "en-US" for all locales. I'm not sure what the correct fix is here.

I'm still looking at the other issue.

Comment 4

[Chris Coulson]

The other issue is a bug in our distribution.ini. It has this line in it:

app.partner.ubuntu = “ubuntu”

Which clearly should be:

app.partner.ubuntu = ubuntu

I don't think this file has been touched for many years, so that's been there a while. After fixing it, it seems to do the job (verified in a JS shell):

>> Components.utils.import("resource://gre/modules/UpdateUtils.jsm")
[object BackstagePass]
>> Components.utils.import("resource://gre/modules/Services.jsm")
[object BackstagePass]
>> var url = Services.prefs.getCharPref("extensions.systemAddon.update.url")
>> UpdateUtils.formatUpdateURL(url)
https://aus5.mozilla.org/update/3/SystemAddons/50.0/20161021085142/Linux_x86_64-gcc3/null/beta-cck-ubuntu/Linux%204.4.0-46-generic%20(GTK%203.18.9%2Clibpulse%208.0.0)/canonical/1.0/update.xml

Comment 5

[[e-mail] (:bhearsum)]

Thanks Chris! It looks like the new URL is working well enough to receive System Addons (checked this by bumping the version back: https://aus5.mozilla.org/update/3/SystemAddons/47.0/20161021085142/Linux_x86_64-gcc3/null/beta-cck-ubuntu/Linux%204.4.0-46-generic%20(GTK%203.18.9%2Clibpulse%208.0.0)/canonical/1.0/update.xml)

We don't currently do any decision making on the server based on locale, so "null" is probably fine at the moment. It wouldn't shock me if we do in the future though, so this might become an issue...I wonder if we should ensure langpacks (whether their ours is yours) set update.locale?

Comment 6

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.