Closed Bug 1311786 Opened 7 years ago Closed 7 years ago

Processing error in ContentChild when GPU process dies

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: dvander, Assigned: rhunt)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

ignore-layer-allocated.patch
878 bytes, patch
Details | Diff | Splinter Review 
If the GPU process crashes before the NotifyLayerAllocated message arrives, the content process will encounter a processing error here:

http://searchfox.org/mozilla-central/rev/703b663355467293fad148ab7c2c5ee2b878e4d9/dom/ipc/ContentChild.cpp#1437

Ryan, if IPC is closed here, should we just return true and ignore it, and wait for TabChild::ReinitRendering to call SendPAPZConstructor?
Flags: needinfo?(rhunt)
Yes that seems like a good solution. I'll make a patch for it.
Assignee: nobody → rhunt
Flags: needinfo?(rhunt)
Attached patch ignore-layer-allocated.patch (obsolete) — — Splinter Review 

        Attachment #8803174 -
        Flags: review?(dvander)

    
    

    
  
Comment on attachment 8803174 [details] [diff] [review]
ignore-layer-allocated.patch

Review of attachment 8803174 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/ContentChild.cpp
@@ +1435,5 @@
>  
>  bool
>  ContentChild::RecvNotifyLayerAllocated(const dom::TabId& aTabId, const uint64_t& aLayersId)
>  {
> +  if (!CompositorBridgeChild::Get()->IPCOpen())

nit: braces

        Attachment #8803174 -
        Flags: review?(dvander) → review+

    
    

    
  


  

        Attachment #8803174 -
        Attachment is obsolete: true

    
  
Keywords: checkin-needed

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffc56d290c8d
Ignore LayerAllocated messages when the GPU process is crashed. r=dvander
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/ffc56d290c8d
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox52:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

          You need to log in
          before you can comment on or make changes to this bug.