Processing error in ContentChild when GPU process dies

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dvander, Assigned: rhunt)

Tracking

(Blocks 1 bug)

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

If the GPU process crashes before the NotifyLayerAllocated message arrives, the content process will encounter a processing error here:

http://searchfox.org/mozilla-central/rev/703b663355467293fad148ab7c2c5ee2b878e4d9/dom/ipc/ContentChild.cpp#1437

Ryan, if IPC is closed here, should we just return true and ignore it, and wait for TabChild::ReinitRendering to call SendPAPZConstructor?
Flags: needinfo?(rhunt)
Assignee

Comment 1

3 years ago
Yes that seems like a good solution. I'll make a patch for it.
Assignee: nobody → rhunt
Flags: needinfo?(rhunt)
Assignee

Comment 2

3 years ago
Posted patch ignore-layer-allocated.patch (obsolete) — Splinter Review
Attachment #8803174 - Flags: review?(dvander)
Comment on attachment 8803174 [details] [diff] [review]
ignore-layer-allocated.patch

Review of attachment 8803174 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/ContentChild.cpp
@@ +1435,5 @@
>  
>  bool
>  ContentChild::RecvNotifyLayerAllocated(const dom::TabId& aTabId, const uint64_t& aLayersId)
>  {
> +  if (!CompositorBridgeChild::Get()->IPCOpen())

nit: braces
Attachment #8803174 - Flags: review?(dvander) → review+
Assignee

Comment 4

3 years ago
Attachment #8803174 - Attachment is obsolete: true
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 5

3 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffc56d290c8d
Ignore LayerAllocated messages when the GPU process is crashed. r=dvander
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ffc56d290c8d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.