1311786 - Processing error in ContentChild when GPU process dies

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

If the GPU process crashes before the NotifyLayerAllocated message arrives, the content process will encounter a processing error here:

http://searchfox.org/mozilla-central/rev/703b663355467293fad148ab7c2c5ee2b878e4d9/dom/ipc/ContentChild.cpp#1437

Ryan, if IPC is closed here, should we just return true and ignore it, and wait for TabChild::ReinitRendering to call SendPAPZConstructor?

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Yes that seems like a good solution. I'll make a patch for it.

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: ignore-layer-allocated.patch

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8803174 [details] [diff] [review]
ignore-layer-allocated.patch

Review of attachment 8803174 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/ContentChild.cpp
@@ +1435,5 @@
>  
>  bool
>  ContentChild::RecvNotifyLayerAllocated(const dom::TabId& aTabId, const uint64_t& aLayersId)
>  {
> +  if (!CompositorBridgeChild::Get()->IPCOpen())

nit: braces

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: ignore-layer-allocated.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffc56d290c8d
Ignore LayerAllocated messages when the GPU process is crashed. r=dvander

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ffc56d290c8d