Closed Bug 1311791 Opened 3 years ago Closed 3 years ago

Ensure hg-shared path is rooted at cache root

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla52

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file)

The patch in bug 1292071 to move the hg store pool as a sibling directory of the checkout was a bit quick and dirty. Before, the directory was in a fixed location: the path to the cache. After, the directory is derived from the checkout path. Because the checkout path can be different across tasks, there can  be different stores, yielding lower cache hits.

We should export a variable or something to the task and restore the fixed shared store path to ensure there is only 1 per cache.
Comment on attachment 8803102 [details]
Bug 1311791 - Explicitly declare path to shared hg store;

https://reviewboard.mozilla.org/r/87312/#review86610

I think you'll need to change .taskcluster.yml as well to match action.yml.  Aside from that, this looks good.
Attachment #8803102 - Flags: review?(dustin) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff5a4bab0813
Explicitly declare path to shared hg store; r=dustin
https://hg.mozilla.org/mozilla-central/rev/ff5a4bab0813
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Blocks: 1312475
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.