1311791 - Ensure hg-shared path is rooted at cache root

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Gregory Szorc [:gps]]

The patch in bug 1292071 to move the hg store pool as a sibling directory of the checkout was a bit quick and dirty. Before, the directory was in a fixed location: the path to the cache. After, the directory is derived from the checkout path. Because the checkout path can be different across tasks, there can  be different stores, yielding lower cache hits.

We should export a variable or something to the task and restore the fixed shared store path to ensure there is only 1 per cache.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1311791 - Explicitly declare path to shared hg store;

332a08725ed0 changed the store path logic in a quick and crude manner.
The code could lead to multiple shared stores existing on a cache
if checkouts were in different parent directories.

This commit refactors the code to explicitly declare a path to the
shared hg store. This restores the behavior of ensuring there is only
a single shared store per cache.

Review commit: https://reviewboard.mozilla.org/r/87312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87312/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8803102 [details]
Bug 1311791 - Explicitly declare path to shared hg store;

https://reviewboard.mozilla.org/r/87312/#review86610

I think you'll need to change .taskcluster.yml as well to match action.yml.  Aside from that, this looks good.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8803102 [details]
Bug 1311791 - Explicitly declare path to shared hg store;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87312/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff5a4bab0813
Explicitly declare path to shared hg store; r=dustin

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff5a4bab0813