Closed
Bug 1311809
Opened 8 years ago
Closed 8 years ago
[mozext] Stringify crash in changesetpushes
Categories
(Developer Services :: Mercurial: mozext, defect)
Developer Services
Mercurial: mozext
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
hg changesetpushes crashes for me because it passes ctx.rev() directly to ui.write.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8803099 -
Flags: review?(gps)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8803099 [details] [diff] [review] [mozext] Fix stringify crash in changesetpushes Review of attachment 8803099 [details] [diff] [review]: ----------------------------------------------------------------- Good catch. This broke a few Mercurial releases ago, as the ui output API got more strict about the types it allows. Blame the lack of test coverage of mozext on this regression.
Attachment #8803099 -
Flags: review?(gps) → review+
Pushed by sfink@mozilla.com: https://hg.mozilla.org/hgcustom/version-control-tools/rev/e6ea986137b6 [mozext] Fix stringify crash in changesetpushes, r=gps
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•