[mozext] Stringify crash in changesetpushes

RESOLVED FIXED

Status

Developer Services
Mercurial: mozext
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
hg changesetpushes crashes for me because it passes ctx.rev() directly to ui.write.
(Assignee)

Comment 1

a year ago
Created attachment 8803099 [details] [diff] [review]
[mozext] Fix stringify crash in changesetpushes
Attachment #8803099 - Flags: review?(gps)
Comment on attachment 8803099 [details] [diff] [review]
[mozext] Fix stringify crash in changesetpushes

Review of attachment 8803099 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch. This broke a few Mercurial releases ago, as the ui output API got more strict about the types it allows. Blame the lack of test coverage of mozext on this regression.
Attachment #8803099 - Flags: review?(gps) → review+

Comment 3

a year ago
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/e6ea986137b6
[mozext] Fix stringify crash in changesetpushes, r=gps
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.