131182 - empty item in the history tab folder context menu

Status: VERIFIED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Emanuele]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020310
BuildID:    20020310

I noticed that in my history tab (in the sidebar) the menu i got with a
right-click has an empty item, that is the "expand/collapse" item that appears
in the history window (tasks/tools/history) correctly. If i click on it mozilla
crashes

Reproducible: Always
Steps to Reproduce:
1.Add the history tab to the sidebar
2.open the menu
3.click on the empty item (a thin space over "open in new window")

Actual Results:  Mozilla crashes

Expected Results:  A collapse/expand action

Comment 1

[Emanuele]

Strange, few hours later it seems not to crash; now clicking on the empty item
make his work; however the label his absent

Comment 2

[Chris Lyon]

Confirming empty folder context menu item on 2002031403 on WinXP - no crash 
though.
Clicking on the empty item Expands/collapses folder.

Seeing this JavaScript Console Error when right clicking on folder:
Error: gHistoryBundle has no properties
Source File: chrome://communicator/content/history/history.js
Line: 416

Comment 3

[Emanuele]

I'm seeing the same problem with RC1

Comment 4

[Emanuele]

I think that this bug is not so hard to fix, but it is open since 0.9.9 and with
1.2b is still present.

Comment 5

[Andreas Kunz]

Attachment: patch: load stringbundle also in sidebar

The stringbundle containing the collapse/expand label is only loaded in the
standalone window history.xul, not in history-panel.xul, so it is not available
in the sidebar.
Patch fixes it.

Comment 6

[Andreas Kunz]

Comment on attachment 138574 [details] [diff] [review]
patch: load stringbundle also in sidebar

Requesting r= from Neil and sr= from alecf.

Comment 7

[Stefan Borggraefe]

The same fix is also part of the second patch for bug 227053.

Comment 8

[Alec Flett]

Comment on attachment 138574 [details] [diff] [review]
patch: load stringbundle also in sidebar

sr=alecf

Comment 9

[Andreas Kunz]

Comment on attachment 138574 [details] [diff] [review]
patch: load stringbundle also in sidebar

Requesting approval for 1.6:
This is really low-risk and very visible (small horizontal bar instead of
context menu entry) - at a moderately visible place, though.

Comment 10

[Andreas Kunz]

Umm... forgot to mention that this was checked into trunk by Neil on 01/08/2004
17:02.
Marking as fixed on trunk (but still hoping for approval).

Comment 11

[Stefan Borggraefe]

v

Comment 12

[Andreas Kunz]

Comment on attachment 138574 [details] [diff] [review]
patch: load stringbundle also in sidebar

1.6 is out, removing approval request.