1311840 - Duplicate TextLogSummaryLine rows

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect)

Description

[James Graham [:jgraham]]

Presumably because we are managing to run crossreference_error_line more than once per job.

Steps to fix:

* Check for existing TextLogSummary before creating any error lines to prevent new bad data

* Correct existing bad data

* Add a unique constraint on text_log_summary_line.failure_line

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:summary_duplicate_1 > mozilla:production

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8803125 [details] [review]
[treeherder] mozilla:summary_duplicate_1 > mozilla:production

See PR for comments but I think this is fine to go in as a stopgap

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:text_log_summary_dupe_remove > mozilla:master

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8803466 [details] [review]
[treeherder] mozilla:text_log_summary_dupe_remove > mozilla:master

This looks reasonable to me, assuming it works. Feel free to carry forward r+ if you make minor modifications.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f769d2dbbc72a83f346d727cf02494fcbd357fba
Bug 1311840 - Bail if we try to run crossreference_error_lines on a job with an existing TextLogSummary (#1942)

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/3f9c754c78c718f705dacf72465d65eaac3d3bc9
Bug 1311840 - Add temporary command to remove duplicate text_log_summary_line entries (#1946)

Comment 8

[Ed Morley [:emorley]]

Is this fixed?

Comment 9

[James Graham [:jgraham]]

It seems to be.