Closed Bug 1311860 Opened 3 years ago Closed 3 years ago

Fix NS_IsMainThread crash for CheckerboardFlushObserver in GPU process

Categories

(Core :: Panning and Zooming, defect, P3)

52 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox51 --- unaffected
firefox52 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Right now we are getting a bunch of try failures with the GPU process in APZCTreeManager when it tries to create a CheckerboardFlushObserver on the compositor thread.
This changes APZCTreeManager to defer the creation of CheckerboardFlushObserver to the main thread. This will also do this when there is no gpu process, but I don't believe that is a problem. The rest of CheckerboardFlushObserver should work thanks to the work in bug 1275314.
Attachment #8803167 - Flags: review?(bugmail)
Comment on attachment 8803167 [details] [diff] [review]
checkerboard-flush.patch

Review of attachment 8803167 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks.
Attachment #8803167 - Flags: review?(bugmail) → review+
Component: Graphics → Panning and Zooming
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
Whiteboard: [gfx-noted]
Version: unspecified → 52 Branch
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8290bf962921
Dispatch CheckerboardFlushObserver creation to main thread. r=kats
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8290bf962921
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.