Closed Bug 1311873 Opened 9 years ago Closed 7 years ago

buildbot DB maintenance should use transactions

Categories

(Release Engineering :: General, defect, P5)

Product:
Release Engineering
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: nthomas, Unassigned)

Details

It chunks up deletion of 10000 builds at a time, but doesn't commit the changes after each chunk, so the DB keeps track of state from the very start of the job to the end. There's a verbose log at bm81:/builds/buildbot/db_maint/test-for-transactions.log The code is at http://hg.mozilla.org/build/tools/file/default/buildfarm/maintenance/cleanup_db.py
Do we gain anything by doing this?
There's no known bustage from this, it's the result of reading https://dev.mysql.com/doc/refman/5.6/en/converting-tables-to-innodb.html#innodb-convert-transactions and realizing we run a 2.5 hour cleanup job every week. I can't find anything of concern in newrelic for the two buildbot db hosts (eg no memory or load spikes).
Priority: -- → P5
Component: Tools → General
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.