1311945 - The menu should not be displayed when foregrounding the app on iPads

Status: VERIFIED FIXED

(Firefox for iOS :: Menu and Toolbar, defect, P3)

Description

[Catalin Suciu [:csuciu]]

iPads
master acc25e6d9

1. Start Firefox
2. Open the menu
3. Background Firefox
4. Foreground Firefox

Expected: The Menu should not be displayed when the app is foregrounded.

Actual: The Menu is briefly shown when the app is foregrounded, then is dismissed.

Comment 1

[Rod Knowlton]

I'd like to fix this bug. Please assign it to me if still valid.

I'm also new to bugzilla. Should it be fixed for both versions 6 and 7, or just 7?

Comment 2

[Aaron Train [:aaronmt]]

(In reply to Rod Knowlton from comment #1)
> I'd like to fix this bug. Please assign it to me if still valid.

For sure, feel free to work on this.
 
> I'm also new to bugzilla. Should it be fixed for both versions 6 and 7, or
> just 7?

We would like to have this fixed for version 7.0, which is currently the master branch.

Comment 3

[Rod Knowlton]

Do we only want the menu dismissed on going to background on iPad? On iPhone, it doesn't get dismissed even upon returning to foreground.

I, personally, think it should be dismissed when going to background on both. That'd be consistent with iOS behaviors in similar circumstances, such as when Share menu is displayed.

Comment 4

[Stephan Leroux [:sleroux]]

> I, personally, think it should be dismissed when going to background on both. That'd be consistent with iOS behaviors in similar circumstances, such as when Share menu is displayed.

I agree - I think having it be consistent on both form factors and with other iOS behaviors would be the way to go.

Comment 5

[Rod Knowlton]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2289

Comment 6

[Stephan Leroux [:sleroux]]

Comment on attachment 8819996 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2289

Looks good. Thanks for the patch!

Comment 7

[Stephan Leroux [:sleroux]]

master https://github.com/mozilla-mobile/firefox-ios/commit/e6640c8ce3a3655a19fe19f0518146ea65f9564c

Comment 8

[Stephan Leroux [:sleroux]]

v6.x 3839230c3390680c88b59301f7ba01ce0cb6b417

Comment 9

[Catalin Suciu [:csuciu]]

Verifying as fixed on v6.0b8. The menu is correctly dismissed when backgrounding/foregrounding the app.