1311960 - Turn on remote media decoding preference on Android.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[John Lin [:jhlin][:jolin]]

Follow up bug of bug 1257777, 1295106.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1311960 - Turn on remote media decoding preference on Android Nightly.

Review commit: https://reviewboard.mozilla.org/r/87600/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87600/

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8803290 [details]
Bug 1311960 - Turn on remote media decoding preference on Android Nightly.

https://reviewboard.mozilla.org/r/87600/#review87070

Looks good, but please make sure you add the ifdef.

::: mobile/android/app/mobile.js:622
(Diff revision 1)
>  
>  // Enable the MediaCodec PlatformDecoderModule by default.
>  pref("media.android-media-codec.enabled", true);
>  pref("media.android-media-codec.preferred", true);
>  // Run decoder in seperate process.
> -pref("media.android-remote-codec.enabled", false);
> +pref("media.android-remote-codec.enabled", true);

Guard this with '#ifdef NIGHTLY_BUILD' for now. We can make a separate decision for riding the trains later on.

Comment 3

[John Lin [:jhlin][:jolin]]

Comment on attachment 8803290 [details]
Bug 1311960 - Turn on remote media decoding preference on Android Nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87600/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baf3f0f96116
Turn on remote media decoding preference on Android Nightly. r=snorp

Comment 5

[Phil Ringnalda (:philor)]

Of the 11 failed jobs on Android on your try push, 10 of them were caused by this patch.

Backed out in https://hg.mozilla.org/integration/autoland/rev/ddb157d399d04145a11031b2af29e1a697d71c4c

Comment 6

[John Lin [:jhlin][:jolin]]

Failed tests passed on my devices and failed on emulators. Will investigate if there are timing issues.

Comment 7

[John Lin [:jhlin][:jolin]]

Two test cases failed when pref is on:
dom/ipc/tests/test_temporaryfile_stream.html -- it happens because MediaRecorder produces zero-duration video frames on emulator. Bug 1313993 was filed to address it.
dom/media/test/crashtests/video-replay-after-audio-end.html -- remote decoder failed to dequeue buffers so the test timed out. Bug 1313991 was filed for this.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1ff94b31819
turn on remote media decoding preference on Fennec Nightly. r=snorp

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b1ff94b31819