1311967 - Update to Django 1.10

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Ed Morley [:emorley]]

Chatting through the taskcluster auth bug with Cameron yesterday, it became apparent that we might need to update to Django 1.10 to get the longer username field.

We'll need to first update to Django 1.9 (bug 1266065) and pick up recent package updates (bug 1302689) since many of them include Django 1.10 compatibility fixes.

After that we'll need to go through the Django 1.10 release notes and check for any straggling packages that don't have Django 1.10 support.

Comment 1

[Ed Morley [:emorley]]

After rebasing on top of bug 1326045 + bug 1324707:

vagrant ~/treeherder $ python -Wonce manage.py check --deploy

/home/vagrant/venv/local/lib/python2.7/site-packages/django/conf/__init__.py:129: RemovedInDjango110Warning: Session verification will become mandatory in Django 1.10. Please add 'django.contrib.auth.middleware.SessionAuthenticationMiddleware' to your MIDDLEWARE_CLASSES setting when you are ready to opt-in after reading the upgrade considerations in the 1.8 release notes.
  RemovedInDjango110Warning
...
/home/vagrant/venv/local/lib/python2.7/site-packages/django/template/utils.py:37: RemovedInDjango110Warning: You haven't defined a TEMPLATES setting. You must do so before upgrading to Django 1.10. Otherwise Django will be unable to load templates.
  "unable to load templates.", RemovedInDjango110Warning)
...


(Also checked `python -Wonce manage.py runserver` and `python -Wonce manage.py migrate` but nothing extra there)

Comment 2

[Ed Morley [:emorley]]

$ PYTHONWARNINGS=once py.test tests --capture=no |& egrep 'RemovedInDjango110Warning|DeprecationWarning'
...
/home/vagrant/venv/local/lib/python2.7/site-packages/django/conf/__init__.py:129: RemovedInDjango110Warning: Session verification will become mandatory in Django 1.10. Please add 'django.contrib.auth.middleware.SessionAuthenticationMiddleware' to your MIDDLEWARE_CLASSES setting when you are ready to opt-in after reading the upgrade considerations in the 1.8 release notes.
  RemovedInDjango110Warning
...
tests/e2e/test_jobs_loaded.py ../home/vagrant/venv/local/lib/python2.7/site-packages/django/template/utils.py:37: RemovedInDjango110Warning: You haven't defined a TEMPLATES setting. You must do so before upgrading to Django 1.10. Otherwise Django will be unable to load templates.
  "unable to load templates.", RemovedInDjango110Warning)
/home/vagrant/treeherder/tests/model/test_cycle_data.py:44: RemovedInDjango110Warning: OptionParser usage for Django management commands is deprecated, use ArgumentParser instead
/home/vagrant/treeherder/tests/model/test_cycle_data.py:112: RemovedInDjango110Warning: OptionParser usage for Django management commands is deprecated, use ArgumentParser instead
/home/vagrant/treeherder/tests/model/test_cycle_data.py:169: RemovedInDjango110Warning: OptionParser usage for Django management commands is deprecated, use ArgumentParser instead
/home/vagrant/treeherder/tests/model/test_cycle_data.py:201: RemovedInDjango110Warning: OptionParser usage for Django management commands is deprecated, use ArgumentParser instead
/home/vagrant/treeherder/tests/model/test_cycle_data.py:237: RemovedInDjango110Warning: OptionParser usage for Django management commands is deprecated, use ArgumentParser instead
tests/model/commands/test_init_datasource.py /home/vagrant/treeherder/tests/model/commands/test_init_datasource.py:27: RemovedInDjango110Warning: OptionParser usage for Django management commands is deprecated, use ArgumentParser instead
./home/vagrant/treeherder/tests/model/commands/test_init_datasource.py:35: RemovedInDjango110Warning: OptionParser usage for Django management commands is deprecated, use ArgumentParser instead
./home/vagrant/treeherder/tests/model/derived/test_jobs_model.py:298: RemovedInDjango110Warning: OptionParser usage for Django management commands is deprecated, use ArgumentParser instead
/home/vagrant/treeherder/tests/model/derived/test_jobs_model.py:312: RemovedInDjango110Warning: OptionParser usage for Django management commands is deprecated, use ArgumentParser instead
/home/vagrant/treeherder/treeherder/webapp/api/auth.py:63: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/filters.py:67: PendingDeprecationWarning: The built in 'rest_framework.filters.DjangoFilterBackend' is pending deprecation. You should use 'django_filters.rest_framework.DjangoFilterBackend' instead.
/home/vagrant/venv/local/lib/python2.7/site-packages/rest_framework/filters.py:48: PendingDeprecationWarning: The built in 'rest_framework.filters.FilterSet' is pending deprecation. You should use 'django_filters.rest_framework.FilterSet' instead.

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:django1.10 > mozilla:master

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:django1.10-management-commands > mozilla:master

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8823350 [details] [review]
[treeherder] mozilla:django1.10-management-commands > mozilla:master

(Obsoleting since the PR had the wrong bug number, was meant to be bug 1328277)

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8823145 [details] [review]
[treeherder] mozilla:django1.10 > mozilla:master

Now that the deps have landed, the tests are passing :-)

Comment 7

[Cameron Dawson [:camd]]

Comment on attachment 8823145 [details] [review]
[treeherder] mozilla:django1.10 > mozilla:master

Thanks for doing this!  Now I can fix the [:30] thing in my PR.  :)

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9766bbda3b964eb9dcb15cb96d808747bd6ddbf4
Bug 1311967 - Mark test_no_missing_migrations as requiring DB access

In Django 1.10 the makemigrations command now requires the database
(see https://code.djangoproject.com/ticket/25850), so this test must
now have the `django_db` annotation.

https://github.com/mozilla/treeherder/commit/57728a7457b4039562e136dfb091b222b0e9c7a3
Bug 1311967 - Update Django from 1.9.12 to 1.10.5

https://docs.djangoproject.com/en/1.10/releases/1.10/
https://docs.djangoproject.com/en/1.10/releases/1.10.1/
https://docs.djangoproject.com/en/1.10/releases/1.10.2/
https://docs.djangoproject.com/en/1.10/releases/1.10.3/
https://docs.djangoproject.com/en/1.10/releases/1.10.4/
https://docs.djangoproject.com/en/1.10/releases/1.10.5/
https://github.com/django/django/compare/1.9.12...1.10.5

Comment 9

[Ed Morley [:emorley]]

Hawkrest wasn't running its own tests against Django 1.10 yet, so I've fixed this with:
https://github.com/kumar303/hawkrest/pull/31