1311982 - PerformanceDatumViewSet.list "ValueError: invalid literal for int() with base 10: ..."

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P2)

Description

[Ed Morley [:emorley]]

We should handle this case gracefully (with an HTTP 400) not HTTP 500.

/treeherder.webapp.api.performance_data:PerformanceDatumViewSet.list

File "/app/treeherder/webapp/api/performance_data.py", line 185, in list
File "/app/.heroku/python/lib/python2.7/site-packages/django/db/models/query.py", line 679, in filter
File "/app/.heroku/python/lib/python2.7/site-packages/django/db/models/query.py", line 697, in _filter_or_exclude
File "/app/.heroku/python/lib/python2.7/site-packages/django/db/models/sql/query.py", line 1310, in add_q
File "/app/.heroku/python/lib/python2.7/site-packages/django/db/models/sql/query.py", line 1338, in _add_q
File "/app/.heroku/python/lib/python2.7/site-packages/django/db/models/sql/query.py", line 1209, in build_filter
File "/app/.heroku/python/lib/python2.7/site-packages/django/db/models/sql/query.py", line 1102, in build_lookup
File "/app/.heroku/python/lib/python2.7/site-packages/django/db/models/lookups.py", line 105, in __init__
File "/app/.heroku/python/lib/python2.7/site-packages/django/db/models/lookups.py", line 143, in get_prep_lookup
File "/app/.heroku/python/lib/python2.7/site-packages/django/db/models/fields/__init__.py", line 1875, in get_prep_lookup
File "/app/.heroku/python/lib/python2.7/site-packages/django/db/models/fields/__init__.py", line 729, in get_prep_lookup
File "/app/.heroku/python/lib/python2.7/site-packages/django/db/models/fields/__init__.py", line 1869, in get_prep_value
 exceptions:ValueError: invalid literal for int() with base 10: 'http://8948474958936717641.owasp.org' 

/api/project/mozilla-inbound/performance/data/

parameters	
job_id   	http://8948474958936717641.owasp.org

Comment 1

[Ed Morley [:emorley]]

https://rpm.newrelic.com/accounts/677903/applications/14179733/traced_errors/70d13c62-9482-11e6-9c7c-b82a72d22a14_26896_32252

Comment 2

[William Lachance (:wlach)]

We should check that the job_id parameter is an integer here, and return a sensible error if it isn't:

https://github.com/mozilla/treeherder/blob/master/treeherder/webapp/api/performance_data.py#L173

Comment 3

[Shruti Jasoria [:ShrutiJ]]

:wlach, I'll work on this bug.

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] SJasoria:Bug_1311982 > mozilla:master

Comment 5

[Shruti Jasoria [:ShrutiJ]]

Comment on attachment 8828925 [details] [review]
[treeherder] SJasoria:Bug_1311982 > mozilla:master

I've made a few changes. Please take a look.

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8828925 [details] [review]
[treeherder] SJasoria:Bug_1311982 > mozilla:master

Left some comments. Please re-r? when feedback is addressed. :)

Comment 7

[Shruti Jasoria [:ShrutiJ]]

Comment on attachment 8828925 [details] [review]
[treeherder] SJasoria:Bug_1311982 > mozilla:master

Made the changes which you had asked for in the PR. I've written a test too. I hope it's good.

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8828925 [details] [review]
[treeherder] SJasoria:Bug_1311982 > mozilla:master

Left some comments on github!

Comment 9

[Shruti Jasoria [:ShrutiJ]]

Comment on attachment 8828925 [details] [review]
[treeherder] SJasoria:Bug_1311982 > mozilla:master

I've made the required changes. I hope it's good now.

Comment 10

[William Lachance (:wlach)]

Comment on attachment 8828925 [details] [review]
[treeherder] SJasoria:Bug_1311982 > mozilla:master

Just needs one small change, pre-emptively r+'ing.

Comment 11

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5ec35f62d0f152688dcdd9ea346faed044e29dad
Bug 1311982 - Handle PerformanceDatumViewSet.list error more gracefully (#2090)

Comment 12

[William Lachance (:wlach)]

Unfortunately this actually broke production. :( Apologies, I should have asked for a unit test to make sure this also worked in the normal case. I'll do up a followup.

Comment 13

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1311982-take2 > mozilla:master

Comment 14

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/21348b70ad8d249096ef1ef728c9931a4f8d3451
Bug 1311982 - Fix accidentally broken endpoint (#2102)