Closed
Bug 1311993
Opened 8 years ago
Closed 8 years ago
Don't use STL wrappers for jsctypes-test
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
754 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Adding DISABLE_STL_WRAPPING fixes linker errors I get with the patch for bug 1277368 on various platforms on Try. I think we now #include <new> via some other headers and the linker complains about a missing mozalloc symbol.
Attachment #8803335 -
Flags: review?(mh+mozilla)
Comment 1•8 years ago
|
||
Comment on attachment 8803335 [details] [diff] [review] Patch Review of attachment 8803335 [details] [diff] [review]: ----------------------------------------------------------------- Without a build log showing the error with the patch for bug 1277368, I can't tell whether this is the desired fix. The only try run I see in that bug is months old, and the log is not available anymore. Plus, it's not rebased on top of bug 1283562.
Attachment #8803335 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 2•8 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #1) > Without a build log showing the error with the patch for bug 1277368, I > can't tell whether this is the desired fix. See the Android builds here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc328d9ee06c6a6363eec060dda2cbd65d9dc0a0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception jsctypes-test uses |new| and we now #include <new>.
Flags: needinfo?(mh+mozilla)
Updated•8 years ago
|
Attachment #8803335 -
Flags: review+
Updated•8 years ago
|
Flags: needinfo?(mh+mozilla)
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b79cb46288d1 Don't use STL wrappers for jsctypes-test. r=glandium
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b79cb46288d1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•