Closed Bug 1311993 Opened 4 years ago Closed 4 years ago

Don't use STL wrappers for jsctypes-test

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Adding DISABLE_STL_WRAPPING fixes linker errors I get with the patch for bug 1277368 on various platforms on Try. I think we now #include <new> via some other headers and the linker complains about a missing mozalloc symbol.
Attachment #8803335 - Flags: review?(mh+mozilla)
Comment on attachment 8803335 [details] [diff] [review]
Patch

Review of attachment 8803335 [details] [diff] [review]:
-----------------------------------------------------------------

Without a build log showing the error with the patch for bug 1277368, I can't tell whether this is the desired fix. The only try run I see in that bug is months old, and the log is not available anymore. Plus, it's not rebased on top of bug 1283562.
Attachment #8803335 - Flags: review?(mh+mozilla)
(In reply to Mike Hommey [:glandium] from comment #1)
> Without a build log showing the error with the patch for bug 1277368, I
> can't tell whether this is the desired fix.

See the Android builds here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc328d9ee06c6a6363eec060dda2cbd65d9dc0a0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

jsctypes-test uses |new| and we now #include <new>.
Flags: needinfo?(mh+mozilla)
Attachment #8803335 - Flags: review+
Flags: needinfo?(mh+mozilla)
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b79cb46288d1
Don't use STL wrappers for jsctypes-test. r=glandium
https://hg.mozilla.org/mozilla-central/rev/b79cb46288d1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.