Closed Bug 1312002 Opened 4 years ago Closed 4 years ago

Invalid data imported on buildbot-master132

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: catlee, Unassigned)

References

Details

We have 38 rows in the statusdb with invalid request times, all coming from buildbot-master132:

mysql> select * from builds, build_properties, properties where builds.id = build_properties.build_id and build_properties.property_id = properties.id and name = 'request_times' and value like '"%';
+-----------+-------------+------------+----------+-----------+---------------------+---------------------+--------+------------------------------------------------+-----------+------+-------------+-----------+-----------+---------------+------------+--------------------------------------------------------------------------------------------------------------------------------------+
| id        | buildnumber | builder_id | slave_id | master_id | starttime           | endtime             | result | reason                                         | source_id | lost | property_id | build_id  | id        | name          | source     | value                    |
+-----------+-------------+------------+----------+-----------+---------------------+---------------------+--------+------------------------------------------------+-----------+------+-------------+-----------+-----------+---------------+------------+--------------------------------------------------------------------------------------------------------------------------------------+
| 110001696 |         705 |     615690 |    13071 |       213 | 2016-10-20 09:08:06 | 2016-10-20 10:32:59 |      2 | scheduler                                      |  16077227 |    0 |   403588549 | 110001696 | 403588549 | request_times | postrun.py | "{'128606532': 1476951285L}"                    |
| 110002178 |         707 |     615690 |    12017 |       213 | 2016-10-20 09:57:12 | 2016-10-20 11:21:48 |      2 | scheduler                                      |  16077868 |    0 |   403590537 | 110002178 | 403590537 | request_times | postrun.py | "{'128608528': 1476952425L}"                    |
| 110002225 |        1217 |     617660 |    13091 |       213 | 2016-10-20 11:58:11 | 2016-10-20 13:31:36 |      2 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16076855 |    0 |   403590741 | 110002225 | 403590741 | request_times | postrun.py | "{'128617915': 1476957176L}"                    |
| 110001499 |         647 |     617389 |    12017 |       213 | 2016-10-21 07:11:54 | 2016-10-21 09:05:05 |      2 | scheduler                                      |  16098960 |    0 |   403587769 | 110001499 | 403587769 | request_times | postrun.py | "{'128779646': 1477020645L}"                    |
| 110001981 |         809 |     616001 |    12017 |       213 | 2016-10-21 09:39:19 | 2016-10-21 10:08:35 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403589681 | 110001981 | 403589681 | request_times | postrun.py | "{'128796252': 1477030286L}"                    |
| 110001919 |         808 |     616001 |    11220 |       213 | 2016-10-21 09:38:46 | 2016-10-21 10:07:58 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403589439 | 110001919 | 403589439 | request_times | postrun.py | "{'128796256': 1477030286L}"                    |
| 110001966 |         807 |     616001 |    13023 |       213 | 2016-10-21 09:38:45 | 2016-10-21 10:08:25 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403589624 | 110001966 | 403589624 | request_times | postrun.py | "{'128796269': 1477030286L}"                    |
| 110001838 |         821 |     617376 |    12066 |       213 | 2016-10-21 09:50:09 | 2016-10-21 10:07:01 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403589114 | 110001838 | 403589114 | request_times | postrun.py | "{'128796295': 1477030294L}"                    |
| 110001868 |         822 |     617376 |    11195 |       213 | 2016-10-21 09:50:09 | 2016-10-21 10:07:23 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403589234 | 110001868 | 403589234 | request_times | postrun.py | "{'128796296': 1477030294L}"                    |
| 110001864 |         820 |     617376 |    13177 |       213 | 2016-10-21 09:50:04 | 2016-10-21 10:07:18 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403589218 | 110001864 | 403589218 | request_times | postrun.py | "{'128796303': 1477030294L}"                    |
| 110001847 |         818 |     617376 |    13126 |       213 | 2016-10-21 09:49:50 | 2016-10-21 10:07:06 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403589150 | 110001847 | 403589150 | request_times | postrun.py | "{'128796304': 1477030294L}"                    |
| 110001853 |         819 |     617376 |    12011 |       213 | 2016-10-21 09:49:51 | 2016-10-21 10:07:12 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403589174 | 110001853 | 403589174 | request_times | postrun.py | "{'128796308': 1477030294L}"                    |
| 110001814 |        1163 |     615958 |    11898 |       213 | 2016-10-21 09:41:39 | 2016-10-21 10:06:44 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403589023 | 110001814 | 403589023 | request_times | postrun.py | "{'128796319': 1477030290L}"                    |
| 110001508 |         315 |     690724 |    13084 |       213 | 2016-10-21 09:50:25 | 2016-10-21 10:01:23 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403587804 | 110001508 | 403587804 | request_times | postrun.py | "{'128796335': 1477030296L}"                    |
| 110001525 |         317 |     690724 |    11947 |       213 | 2016-10-21 09:51:32 | 2016-10-21 10:02:32 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403587866 | 110001525 | 403587866 | request_times | postrun.py | "{'128796421': 1477030296L}"                    |
| 110001548 |         316 |     690724 |    11912 |       213 | 2016-10-21 09:50:52 | 2016-10-21 10:01:50 |      0 | Self-serve: Rebuilt by trigger-bot@mozilla.com |  16098334 |    0 |   403587959 | 110001548 | 403587959 | request_times | postrun.py | "{'128796435': 1477030296L}"                    |
| 110001535 |         318 |     690724 |    12018 |       213 | 2016-10-21 09:51:32 | 2016-10-21 10:02:43 |      0 | scheduler                                      |  16100821 |    0 |   403587904 | 110001535 | 403587904 | request_times | postrun.py | "{'128802211': 1477036125L}"                    |
| 110000261 |         584 |     615167 |    13081 |       213 | 2016-10-21 09:03:13 | 2016-10-21 09:45:22 |      2 | scheduler                                      |  16100046 |    0 |   403582433 | 110000261 | 403582433 | request_times | postrun.py | "{'128808996': 1477040446L}"                    |
| 110000250 |         190 |     636222 |    12067 |       213 | 2016-10-21 09:10:17 | 2016-10-21 09:45:15 |      0 | scheduler                                      |  16100575 |    0 |   403582389 | 110000250 | 403582389 | request_times | postrun.py | "{'128809405': 1477040559L, '128809378': 1477040559L, '128809387': 1477040559L, '128809369': 1477040559L, '128809396': 1477040559L}" |
| 110000324 |          59 |     614796 |    13071 |       213 | 2016-10-21 09:25:06 | 2016-10-21 09:46:09 |      0 | scheduler                                      |  16099732 |    0 |   403582693 | 110000324 | 403582693 | request_times | postrun.py | "{'128812137': 1477041750L}"                    |
| 110000308 |          12 |     623868 |    11904 |       213 | 2016-10-21 09:24:54 | 2016-10-21 09:45:53 |      0 | scheduler                                      |  16099732 |    0 |   403582624 | 110000308 | 403582624 | request_times | postrun.py | "{'128812172': 1477041750L}"                    |
| 110001560 |         305 |     660103 |    11875 |       213 | 2016-10-21 09:31:51 | 2016-10-21 10:01:55 |      0 | scheduler                                      |  16100433 |    0 |   403587999 | 110001560 | 403587999 | request_times | postrun.py | "{'128812228': 1477041825L}"                    |
| 110001874 |         294 |     667237 |    11931 |       213 | 2016-10-21 09:32:36 | 2016-10-21 10:07:29 |      0 | scheduler                                      |  16100883 |    0 |   403589258 | 110001874 | 403589258 | request_times | postrun.py | "{'128812847': 1477042140L, '128812929': 1477042140L}"                    |
| 110001593 |           6 |     673506 |    12021 |       213 | 2016-10-21 09:37:13 | 2016-10-21 10:03:30 |      0 | scheduler                                      |  16100833 |    0 |   403588131 | 110001593 | 403588131 | request_times | postrun.py | "{'128812943': 1477042140L, '128812861': 1477042140L}"                    |
| 110001520 |         277 |     618042 |    11915 |       213 | 2016-10-21 09:41:58 | 2016-10-21 10:01:30 |      0 | Self-serve: Rebuilt by cbook@mozilla.com       |  16099499 |    0 |   403587846 | 110001520 | 403587846 | request_times | postrun.py | "{'128813566': 1477042914L}"                    |
| 110001924 |          96 |     626354 |    13022 |       213 | 2016-10-21 09:44:12 | 2016-10-21 10:08:02 |      0 | scheduler                                      |  16100894 |    0 |   403589451 | 110001924 | 403589451 | request_times | postrun.py | "{'128813628': 1477042949L, '128813710': 1477042949L}"                    |
| 110001651 |         250 |     619848 |    12067 |       213 | 2016-10-21 09:46:07 | 2016-10-21 10:04:25 |      0 | scheduler                                      |  16100849 |    0 |   403588365 | 110001651 | 403588365 | request_times | postrun.py | "{'128813659': 1477042949L, '128813577': 1477042949L}"                    |
| 110001543 |         439 |     625216 |    12031 |       213 | 2016-10-21 09:44:18 | 2016-10-21 10:01:44 |      0 | scheduler                                      |  16100822 |    0 |   403587939 | 110001543 | 403587939 | request_times | postrun.py | "{'128813707': 1477042949L, '128813625': 1477042949L}"                    |
| 110002185 |         475 |     625420 |    13038 |       213 | 2016-10-21 09:44:17 | 2016-10-21 10:11:14 |      0 | scheduler                                      |  16100931 |    0 |   403590565 | 110002185 | 403590565 | request_times | postrun.py | "{'128813718': 1477042949L, '128813636': 1477042949L}"                    |
| 110002081 |         241 |     658223 |    13071 |       213 | 2016-10-21 09:48:18 | 2016-10-21 10:09:50 |      0 | scheduler                                      |  16100691 |    0 |   403590106 | 110002081 | 403590106 | request_times | postrun.py | "{'128813809': 1477042965L}"                    |
| 110001631 |         112 |     619380 |    13153 |       213 | 2016-10-21 09:54:12 | 2016-10-21 10:04:06 |      0 | scheduler                                      |  16099901 |    0 |   403588285 | 110001631 | 403588285 | request_times | postrun.py | "{'128814596': 1477043500L}"                    |
| 110001658 |           5 |     617701 |    12079 |       213 | 2016-10-21 09:54:24 | 2016-10-21 10:04:32 |      0 | scheduler                                      |  16099901 |    0 |   403588397 | 110001658 | 403588397 | request_times | postrun.py | "{'128814602': 1477043500L}"                    |
| 110002153 |          12 |     618939 |    11949 |       213 | 2016-10-21 09:56:52 | 2016-10-21 10:10:51 |      0 | scheduler                                      |  16099901 |    0 |   403590441 | 110002153 | 403590441 | request_times | postrun.py | "{'128814604': 1477043500L}"                    |
| 110001678 |          29 |     622800 |    13109 |       213 | 2016-10-21 09:56:31 | 2016-10-21 10:04:46 |      0 | scheduler                                      |  16099901 |    0 |   403588470 | 110001678 | 403588470 | request_times | postrun.py | "{'128814606': 1477043500L}"                    |
| 110001972 |         130 |     625049 |    11199 |       213 | 2016-10-21 09:57:04 | 2016-10-21 10:08:29 |      0 | scheduler                                      |  16099901 |    0 |   403589644 | 110001972 | 403589644 | request_times | postrun.py | "{'128814618': 1477043500L}"                    |
| 110001561 |          43 |     615693 |    13135 |       213 | 2016-10-21 09:56:23 | 2016-10-21 10:03:00 |      0 | scheduler                                      |  16099901 |    0 |   403588004 | 110001561 | 403588004 | request_times | postrun.py | "{'128814623': 1477043500L}"                    |
| 110001911 |           2 |     617480 |    13117 |       213 | 2016-10-21 09:57:08 | 2016-10-21 10:07:53 |      0 | scheduler                                      |  16099901 |    0 |   403589407 | 110001911 | 403589407 | request_times | postrun.py | "{'128814641': 1477043500L}"                    |
| 110001810 |           5 |     632003 |    13086 |       213 | 2016-10-21 09:56:39 | 2016-10-21 10:06:40 |      0 | scheduler                                      |  16099901 |    0 |   403589005 | 110001810 | 403589005 | request_times | postrun.py | "{'128814651': 1477043500L}"                    |
+-----------+-------------+------------+----------+-----------+---------------------+---------------------+--------+------------------------------------------------+-----------+------+-------------+-----------+-----------+---------------+------------+--------------------------------------------------------------------------------------------------------------------------------------+

It looks like request_times are doubly encoded or something. This is breaking our reporting (see bug 1311964)
I fixed these up by decoding the values as json, eval()'ing as python expressions, re-encoding as json, and writing back to the database.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Sorry! I was testing a fix for bug 1308957, and made some bad decisions about where to do that.
See Also: → 1308957
Product: Release Engineering → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.