Closed
Bug 1312015
Opened 8 years ago
Closed 8 years ago
TPS should fail if we error when generating a sync ping record.
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: tcsc, Assigned: tcsc)
Details
Attachments
(1 file)
Right now it's a silent error (maybe worth noting that it's much easier to test this via TPS than via unit tests due to how much gets mocked in the unit tests).
|
||
Updated•8 years ago
|
Priority: -- → P1
|
|
||
Updated•8 years ago
|
Assignee: nobody → tchiovoloni
| Comment hidden (mozreview-request) |
|
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8804348 [details] Bug 1312015 - Ensure that TPS catches failures when generating sync telemetry https://reviewboard.mozilla.org/r/88360/#review87536
Attachment #8804348 -
Flags: review?(markh) → review+
Pushed by tchiovoloni@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7a0e93ea0478 Ensure that TPS catches failures when generating sync telemetry r=markh
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7a0e93ea0478
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in
before you can comment on or make changes to this bug.
Description
•