1312084 - Clicking the Hello button on a new profile in DevEdition forces the user into an infinite loop of new windows opening

Status: RESOLVED INCOMPLETE

(Toolkit :: Application Update, defect)

Description

[Dan Callahan [:callahad]]

Video: http://people.mozilla.org/~dcallahan/tmp/hello.mp4

Repro'd with DevEdition 51.0a2, BuildID 20161021004016

STR:

1. Create a new profile
2. Click the "Hello" Button

What Should Happen:

1. The Hello button shouldn't be there at all
2. When I click it, something reasonable should happen

What Actually Happens:

1. Infinite loop of new windows opening to about:home

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Whoa - why is that button even there anymore?

Comment 2

[Mark Banner (:standard8)]

We've removed all instances of Hello from Firefox, so it shouldn't be there. The only possibilities I can think of are:

- its a self build that's been updated but hadn't got clobber (though Dan's wording implies non-self build)
- The app bundle could have been updated from an older one and for sone reason Hello was left in (check in Contents/Resources/browser/features iirc) 
- Somehow an old version of the Firefox Hello Beta add-on from AMO is being picked up in the fresh profile

Dan, can you please check what is listed in about:support and in the Add-on Manager for Hello. If it is listed, please could you check in the app bundle for the xpi (it'll be loop@ something) and in the created profile?

That might be a start as to what is going on here.

Comment 3

[Dan Callahan [:callahad]]

The plot thickens :)

- This is not a self-build. It's an official build that I first downloaded in early 2015, and have used the auto-updater on ever since.
- The add-on DOES NOT appear in the Add-on Manager
- The add-on DOES appear in about:support (Firefox Hello, version 1.4.3, ID [e-mail])
- There is a [e-mail] in FirefoxDeveloperEdition.app/Contents/Resources/browser/features

Comment 4

[Mark Banner (:standard8)]

Ok so FF still sees it as a system add-on. Looks like for some reason it didn't get removed on update. I guess that's the update system then. What I do know is that it does appear to have removed itself for most people as the stats have gone down.

Comment 5

[Mark Banner (:standard8)]

Note: Loop was removed from the build in FF 49

Comment 6

[Robert Strong (they/them - no direct email)]

App update doesn't do anything special for system add-ons and I haven't changed mar generation to do anything special for them as well. It could be due to the way system add-ons are added to the build since they need to be added before the precomplete file is generated. Please attach the precomplete file for the build it updated from and if possible the update logs for the system after the system has been updated.

Comment 7

[Robert Strong (they/them - no direct email)]

Dan, could you do the following?

In about:config change devtools.chrome.enabled to true

Open Tools -> Web Developer -> Browser Console

Copy the following into the box at the bottom of the Browser Console and press return

var fileLocator = Cc["@mozilla.org/file/directory_service;1"].getService(Ci.nsIProperties); var dir = fileLocator.get("UpdRootD", Ci.nsIFile); dir.reveal();

Open the updates directory inside the directory that is displayed.
Attach the last-backup.log and if present the backup-update.log to this bug.

Thanks!

Comment 8

[Robert Strong (they/them - no direct email)]

Adding qawanted in the hope someone can check if they can reproduce this.

Comment 9

[Mark Banner (:standard8)]

I haven't heard any more about this, or any more instances. I think we can probably mark this as incomplete, due to the lack of info.

Dan: If you can get more info as per comment 7, please reopen.