Closed Bug 1312101 Opened 3 years ago Closed 3 years ago

Remove AppProcessChecker and code that depends on it

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Attachment #8803508 - Flags: review?(amarchesini)
Blocks: nukeb2g
Assignee: nobody → ehsan
Didn't get the review in time.  Need to look at this again at some point.
Flags: needinfo?(ehsan)
Comment on attachment 8803508 [details] [diff] [review]
Remove AppProcessChecker and code that depends on it

Review of attachment 8803508 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsFrameMessageManager.cpp
@@ +1893,5 @@
>      if (aCpows && !cc->GetCPOWManager()->Wrap(aCx, aCpows, &cpows)) {
>        return false;
>      }
>      if (aIsSync) {
>        return cc->SendSyncMessage(PromiseFlatString(aMessage), data, cpows,

move aRetval to this line.

@@ +1899,3 @@
>      }
>      return cc->SendRpcMessage(PromiseFlatString(aMessage), data, cpows,
> +                              aRetVal);

same here.

::: dom/base/nsIMessageManager.idl
@@ +285,3 @@
>                          [optional] in jsval transfers);
>  
>   /**

remove the comment at line 188 too.

::: dom/ipc/ContentParent.cpp
@@ +1295,5 @@
>  
>    mMessageManager->ReceiveMessage(
>        static_cast<nsIContentFrameMessageManager*>(mMessageManager.get()), nullptr,
>        CHILD_PROCESS_SHUTDOWN_MESSAGE, false,
> +      nullptr, nullptr, nullptr);

This is a funny indentation.

@@ +3070,5 @@
>    return true;
>  }
>  
>  PTelephonyParent*
>  ContentParent::AllocPTelephonyParent()

do we still have PTelephony?

::: dom/ipc/PBrowser.ipdl
@@ +202,5 @@
>  
>      async Event(RemoteDOMEvent aEvent);
>  
>      sync SyncMessage(nsString aMessage, ClonedMessageData aData,
> +                     CpowEntry[] aCpows)

same line?

::: dom/ipc/PContent.ipdl
@@ +850,5 @@
>      sync ReadDataStorageArray(nsString aFilename)
>        returns (DataStorageItem[] retValue);
>  
>      sync SyncMessage(nsString aMessage, ClonedMessageData aData,
> +                     CpowEntry[] aCpows)

same line?

@@ +1182,5 @@
>       sync GetA11yContentId() returns (uint32_t aContentId);
>  
>  both:
>       async AsyncMessage(nsString aMessage, CpowEntry[] aCpows,
> +                        ClonedMessageData aData);

same line?

::: dom/ipc/PContentBridge.ipdl
@@ +43,5 @@
>      manages PSendStream;
>  
>  parent:
>      sync SyncMessage(nsString aMessage, ClonedMessageData aData,
> +                     CpowEntry[] aCpows)

same line?

@@ +61,5 @@
>  
>      async PFileDescriptorSet(FileDescriptor fd);
>  
>      async AsyncMessage(nsString aMessage, CpowEntry[] aCpows,
> +                       ClonedMessageData aData);

same line?
Attachment #8803508 - Flags: review?(amarchesini) → review+
Depends on: 1317983
Since AddProcessChecker is going away, there's no point in these
permission checks any more.
Attachment #8811254 - Flags: review?(amarchesini)
Attachment #8811254 - Flags: review?(amarchesini) → review+
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba4af4705e58
Part 1: Remove permission assertions through the message manager; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad3f41ebb1a2
Part 2: Remove AppProcessChecker and code that depends on it; r=baku
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/211be78bea44
follow-up: Remove EnsureRequiredPermissions() as well
No longer blocks: 1369194
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.