1312104 - minor cleanups in indexedDB Key code

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Nathan Froyd [:froydnj]]

We have better ways of writing some of the floating-point serialization bits.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - use BitwiseCast for punning between uint64_t/double in indexedDB

We have code elsewhere for this sort of stuff; let's use it here.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - use FloatingPoint<>::kSignBit in lieu of hand-rolled constant

This way is a little bit more readable.

Comment 3

[Jan Varga [:janv]]

Comment on attachment 8803510 [details] [diff] [review]
part 1 - use BitwiseCast for punning between uint64_t/double in indexedDB

Review of attachment 8803510 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

btw, there's one more "pun" in dom/indexedDB/ActorsParent.cpp, DatabaseOperationBase::ReinterpretDoubleAsUInt64()

Comment 4

[Jan Varga [:janv]]

Comment on attachment 8803511 [details] [diff] [review]
part 2 - use FloatingPoint<>::kSignBit in lieu of hand-rolled constant

Review of attachment 8803511 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/Key.cpp
@@ +616,2 @@
>                      (0 - bits) :
> +                    (bits | signbit);

Nit: merge into one line ?

@@ +642,1 @@
>                    (0 - number);

dtto

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22876ba02fee
part 1 - use BitwiseCast for punning between uint64_t/double in indexedDB; r=janv
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c10b3a0b1e2
part 2 - use FloatingPoint<>::kSignBit in lieu of hand-rolled constant; r=janv

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/22876ba02fee
https://hg.mozilla.org/mozilla-central/rev/9c10b3a0b1e2