Closed Bug 1312152 Opened 5 years ago Closed 5 years ago

Stop using nsIDialogParamBlock in the client auth UI

Categories

(Core :: Security: PSM, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

nsIDialogParamBlock isn't a great API, and is best avoided.
Comment on attachment 8803680 [details]
Bug 1312152 - Stop using nsIDialogParamBlock in the client auth UI.

https://reviewboard.mozilla.org/r/87824/#review87152

Awesome - this is a much better api.
Attachment #8803680 - Flags: review?(dkeeler) → review+
Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4139d045bca4bfa1bf8612b95d75232abd821eea
The SM(arm) orange is Bug 1311419, the others look unrelated.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35996f91e760
Stop using nsIDialogParamBlock in the client auth UI. r=keeler
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/35996f91e760
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.