1312154 - Stop using nsIDialogParamBlock in downloadcert.(js|xul)

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

nsIDialogParamBlock isn't a great API, and is best avoided.

Comment 1

[:Cykesiopka]

Attachment: Bug 1312154 – Stop using nsIDialogParamBlock in downloadcert.(js|xul).

nsIDialogParamBlock isn't a great API, and is best avoided.

This patch also updates downloadcert.js to match modern PSM style, and adds a
test.

Review commit: https://reviewboard.mozilla.org/r/88994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88994/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8805218 [details]
Bug 1312154 – Stop using nsIDialogParamBlock in downloadcert.(js|xul).

https://reviewboard.mozilla.org/r/88994/#review88664

Great - r=me. I don't know if I mentioned this before, but I think this feature is a bit suspect (that is, that any website can serve up a certificate with the right mime type and the browser will say, "hey, did you want to add a new trust anchor?"). I tried to remove it in bug 1024871, but I haven't yet succeeded (one issue is that otherwise there's no way to import a new root certificate on Android (maybe this could be addressed by implementing a "enterprise roots"-like feature on Android)). That all said, it's good to have a test, and the cleanup looks good.

Comment 3

[:Cykesiopka]

Thanks!

(In reply to David Keeler [:keeler] (use needinfo?) from comment #2)
> I think this feature is a bit suspect
I agree, FWIW.

> one issue is that otherwise there's no way to import a new root certificate on Android
This UI is also used when importing CA certs in the cert manager on Desktop platforms.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc8c9fda24d7337bdb01f18413d3d946f890bf4c

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52df9f0848ce
– Stop using nsIDialogParamBlock in downloadcert.(js|xul). r=keeler

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/52df9f0848ce