Closed Bug 1312154 Opened 5 years ago Closed 5 years ago
Stop using ns
IDialog Param Block in downloadcert .(js|xul)
58 bytes, text/x-review-board-request
nsIDialogParamBlock isn't a great API, and is best avoided.
Comment on attachment 8805218 [details] Bug 1312154 – Stop using nsIDialogParamBlock in downloadcert.(js|xul). https://reviewboard.mozilla.org/r/88994/#review88664 Great - r=me. I don't know if I mentioned this before, but I think this feature is a bit suspect (that is, that any website can serve up a certificate with the right mime type and the browser will say, "hey, did you want to add a new trust anchor?"). I tried to remove it in bug 1024871, but I haven't yet succeeded (one issue is that otherwise there's no way to import a new root certificate on Android (maybe this could be addressed by implementing a "enterprise roots"-like feature on Android)). That all said, it's good to have a test, and the cleanup looks good.
Attachment #8805218 - Flags: review?(dkeeler) → review+
Thanks! (In reply to David Keeler [:keeler] (use needinfo?) from comment #2) > I think this feature is a bit suspect I agree, FWIW. > one issue is that otherwise there's no way to import a new root certificate on Android This UI is also used when importing CA certs in the cert manager on Desktop platforms. https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc8c9fda24d7337bdb01f18413d3d946f890bf4c
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/52df9f0848ce – Stop using nsIDialogParamBlock in downloadcert.(js|xul). r=keeler
You need to log in before you can comment on or make changes to this bug.