1312215 - [GTK2] Rendering of XUL checkboxes and radiobuttons focus ring is misaligned with OpenSUSE default desktop theme

Status: NEW

(SeaMonkey :: Themes, defect)

Description

[rsx11m]

Tested with official Linux x86_64 SeaMonkey 2.46 candidate build #6.

When used with the default KDE4 plasma/oxygen desktop on OpenSUSE 13.2, the build shows a rendering problem with XUL checkboxes and radiobuttons in dialog boxes where the focus ring is not aligned with the checkbox or radio element but with the label instead (screenshot follows).

While not a functional problem, it looks weird and didn't occur on the same machine with the same setup using 2.40; this problem does *not* occur on a SLES 11 machine with the default OpenSUSE desktop theme using KDE4 (which employs a different rendering of the focus ring to start with).

Comment 1

[rsx11m]

Attachment: Screenshot of Preferences checkbox

Top row: Focus is *not* on checkbox, mouse hovers over checkbox (ok)
Center:  Focus is on checkbox, *and hover (broken)
Bottom:  Focus is on checkbox, no hover (broken)

BTW: The same can be seen with the (few) modal XUL dialogs that remain in Firefox 49.0, using the OpenSUSE RPM version which is built with GTK2 as well.

Comment 2

[rsx11m]

Some more testing on the focus ring around checkboxes:

 - This only affects XUL checkboxes in dialogs, checkboxes on web pages don't exhibit the issue
   - e.g., using test case from bug 1239213 attachment 8707294 [details]

 - the Modern theme is not affected on the same desktop theme and setup (outlines the entire box)

 - adriank's Linux mozilla-release build is not affected, but uses GTK3 (outlines the label)
   - interestingly, that build isn't affected by bug 1239213 not showing a focus ring at all with GTK3

 - it appears that the desktop theme overrides the definition in checkbox.css to outline the label:
   https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/linux/global/checkbox.css#54

Comment 3

[rsx11m]

This doesn't seem to affect the current Leap 42.1 default desktop theme (tested on a different machine, though), thus may be of limited impact unless other Linux users see this issue as well.

Can someone else check with the current release builds?

Comment 4

[Tony Mechelynck [:tonymec]]

(In reply to rsx11m from comment #3)
> This doesn't seem to affect the current Leap 42.1 default desktop theme
> (tested on a different machine, though), thus may be of limited impact
> unless other Linux users see this issue as well.
> 
> Can someone else check with the current release builds?

Don't know: I use trunk builds, which are built with GTK3. I might try a release build in a new profile one of these days, but I hope I won't have to. I'll leave my NEEDINFO on for the time being; please clear it, someone, after you've tested it yourself.

Comment 5

[Frank-Rainer Grahl (:frg)]

Do not have a current openSUSE installed. 2.46 Candidate 6 looks fine in CentOS 7.2 

KDE 4.14.8 oxygen-gtk

Comment 6

[rsx11m]

(In reply to Frank-Rainer Grahl from comment #5)
> Do not have a current openSUSE installed. 2.46 Candidate 6 looks fine in CentOS 7.2 

Thanks for testing. Yes, it was also my intention to see if it affects other distributions as well.
If this is only a problem for a specific version of a specific distro, probably a don't-care issue.

Comment 7

[Frank-Rainer Grahl (:frg)]

No problem with Debian 8.5 either.

Comment 8

[Tony Mechelynck [:tonymec]]

nightly/latest-comm-release/ is a 2.45 from 12 August. Let's see if I can find something newer.

Ah, this one might be interesting: http://ftp.mozilla.org/pub/seamonkey/candidates/2.46-candidates/build6/linux-x86_64/en-US/ from 5 October.

Or even that one: http://ftp.mozilla.org/pub/seamonkey/tinderbox-builds/comm-release-linux64/1480921568/ which is a 2.47 from 5 December. No "2.47 candidates" yet in the candidates/ tree BTW.

I see other people have tested the 2.46 candidate build 6, so let's try it too. For the record, my current OS is now the recently published (November 16) openSUSE Leap 42.2, i.e. the current openSUSE "stable" release.

After installing that 2.46c6 at a non-conflicting place (its installdir is ~/seamonkey/ rather than /usr/local/seamonkey/ as for my usual workhorse) I start it with

~/seamonkey/seamonkey -ProfileManager --new-instance >> ~/seamonkey-2.46.log 2>&1 &

Creating a new profile seems OK.
Caveat: I have no configured mail so I didn't test that. Let's (at first) start only the browser.
Page http://www.seamonkey-project.org/releases/seamonkey2.46/ is 404 Not Found — probably OK.
http://www.seamonkey-project.org/ — OK.
https://bugzilla.mozilla.org/ (didn't try to log in) — OK.
about:addons — ohoh, cZ, DOMi and Lightning are present, but "ChatZilla will be updated after you restart SeaMonkey" — 0.9.92 to 0.9.93 I suppose? Let's try that.
Restart Now — OK.
Let's start ChatZilla, connect to moznet and join #seamonkey.
  NickServ knows me.
  /ns identify OK
  /join OK
  hello back and forth between cZ in 2.46c6 and cZ in 2.50a1 OK.

Let's call it a day. After shutting it down I'll attach its log to this bug.
Rsx11m, if you want other tests, please say what.
And if you want me to test the "2.47 release tinderbox-build" say it too.
Needinfo in both cases please, or I might be slow to notice it.

Comment 9

[Tony Mechelynck [:tonymec]]

Attachment: log of 2.46c6 test in new profile on openSUSE Leap 42.2, see comment #8

Nothing untoward AFAICT.

Comment 10

[Tony Mechelynck [:tonymec]]

Apparently I should have read comment #0 to #3 first. I'm not sure what my desktop theme is. Gnome? Yes, I think so, Gnome 3.20.2.

Comment 11

[rsx11m]

Tony, thanks for testing. So, you didn't see attachment 8803648 [details] with Leap 42.2?

Comment 12

[Tony Mechelynck [:tonymec]]

(In reply to rsx11m from comment #11)
> Tony, thanks for testing. So, you didn't see attachment 8803648 [details]
> with Leap 42.2?

I don't remember ever having seen prefs dialog abnormal in this way; however, my window manager is not KDE Plasma but Gnome.

Comment 13

[Jonathan Watt [:jwatt]]

GTK2 support was removed from the Mozilla source at the beginning of 2018 in bug 1278282, in case that's relevant here.