pulse notifier got stuck processing obsolescence markers

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Earlier today, I pushed to one of my user repos. Something in the obsolescence markers made the obsolescence marker dumping command crash. This got into an infinite loop and crashed the pulse notifier service.

There's an obvious bug in handling obsolescence markers.

I also discovered we don't have a good way to skip messages in the pulse notifier. In the replication consumer, you can skip messages. So if a message fails to apply you just skip and restart the server and everything recovers. We need a way to skip bad messages in the pulse consumer as well.
(Assignee)

Updated

2 years ago
Depends on: 1312235

Updated

2 years ago
Blocks: 1312235
No longer depends on: 1312235
(Assignee)

Updated

2 years ago
Assignee: nobody → gps
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8803932 [details]
vcsreplicator: teach pulse notifier to skip messages (bug 1312238);

https://reviewboard.mozilla.org/r/88128/#review87100

shipit!
Attachment #8803932 - Flags: review?(klibby) → review+

Comment 3

2 years ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/39f6d28ff7e1
vcsreplicator: teach pulse notifier to skip messages ; r=fubar
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.