1312239 - In tabmail.xml use plain for..of on arrays and Object.entries() instead of Iterator()

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[:aceman]

In mail/base/tabmail.xml there are some arrays that are iterated over via Iterator() or Array.entries(). Those can be simplified.

Comment 1

[:aceman]

Attachment: patch

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=f52aa3f5297a729d949c87ac5bfc20e2986ac445

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8803669 [details] [diff] [review]
patch

Review of attachment 8803669 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good overall, r=mkmelin

::: mail/base/content/tabmail.xml
@@ +341,5 @@
>            if (aTabType.name in this.tabTypes)
>              return;
>  
>            this.tabTypes[aTabType.name] = aTabType;
> +          for (let [modeName, modeDetails] of Object.entries(aTabType.modes)) {

this one looks a little suspicious, please double check it's correct

Comment 3

[:aceman]

Thanks.

I checked it now, dumped the returned objects (even modeDetails.toSource()) and they are the same with old and new code.

Comment 4

[:aceman]

https://hg.mozilla.org/comm-central/rev/f0360f50e7a4d73a9d226e86dcfa19447e4148f6