1312290 - Respect Arch Linux custom package file extension when building AUR packages

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Leo Schwarz]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20161020004015

Steps to reproduce:

On Arch Linux it's possible to change the extensions of packages created using makepkg by editing the last lines of `/etc/makepkg.conf`. Specifically PKGEXT and SRCEXT can be overwritten to a format that takes less time compressing (e.g. ".tar" or ".tar.gz") than the default ".tar.xz".

To reproduce set to ".tar.gz" or ".tar". Then in a new mozilla-central clone run `./mach bootstrap`.


Actual results:

AUR package gets built but when mach scripts try finding the ".xz" file it fails and `./mach bootstrap` is aborted.

The error takes place in mozboot/mozboot/archlinux.py inside the method `ArchlinuxBootstrapper.makepkg`.

>IndexError: list index out of range
>
>  File "/home/leo/Projekte/mozilla-central/python/mozboot/mozboot/mach_commands.py", line 26, in bootstrap
>    bootstrapper.bootstrap()
>  File "/home/leo/Projekte/mozilla-central/python/mozboot/mozboot/bootstrap.py", line 228, in bootstrap
>    getattr(self.instance, 'install_%s_packages' % application)()
>  File "/home/leo/Projekte/mozilla-central/python/mozboot/mozboot/archlinux.py", > line 85, in install_browser_packages
>    self.ensure_browser_packages()
>  File "/home/leo/Projekte/mozilla-central/python/mozboot/mozboot/archlinux.py", >line 98, in ensure_browser_packages
>    self.aur_install(*self.BROWSER_AUR_PACKAGES)
>  File "/home/leo/Projekte/mozilla-central/python/mozboot/mozboot/archlinux.py", > line 219, in aur_install
>    self.makepkg(name)
>  File "/home/leo/Projekte/mozilla-central/python/mozboot/mozboot/archlinux.py", >line 193, in makepkg
>    pack = glob.glob(name + '*.tar.xz')[0]



Expected results:

There are multiple options and as I assume you might not want to support customized environments like this I think it should at least fail gracefully and instruct the user which packages to install manually.

Options:
– Extract the correct package extension and use it to look for the script.
– Find an AUR helper installed on the system and let it handle compilation and installation (eg. pacaur).
– Embed AUR helper (but this would be quite a heavy dependency I guess)
– In case of failure display a list of space separated AUR packages that are to be installed (then a user could just use their own AUR manager to build and install said packages). This would probably be the most lightweight option.

Comment 1

[Leo Schwarz]

Attachment: Bug 1312290 - Force package extension when building AUR packages on Arch Linux.

Previously if an Arch Linux user had a different package extension configured
in `/etc/makepkg.conf` building AUR packages during bootstrap would fail.
Forcing the extension by providing it as an environment variable makes sure
building doesn't fail regarding of a user's configuration.

Review commit: https://reviewboard.mozilla.org/r/88286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88286/

Comment 2

[Leo Schwarz]

I submitted a fix here: https://reviewboard.mozilla.org/r/88286/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8804171 [details]
Bug 1312290 - Force package extension when building AUR packages on Arch Linux.

https://reviewboard.mozilla.org/r/88286/#review88146

Thanks for fixing this and for enlightening us on how packaging environments can differ slightly.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/490cc18cf93f
Force package extension when building AUR packages on Arch Linux. r=gps

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/490cc18cf93f