1312324 - Add test to confirm that fullscreen should(not) be available accordingly when video in an iframe

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Ray Lin[:ralin]]

Fullscreen should be unavailable by default when video in an iframe. However, if iframe has `allowfullscreen` attribute should be available then.

Comment 1

[Ray Lin[:ralin]]

Attachment: Bug 1312324 - Add test to confirm fullscreen availability when video in an iframe.

Review commit: https://reviewboard.mozilla.org/r/87904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87904/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8803764 [details]
Bug 1312324 - Add test to confirm fullscreen availability when video in an iframe.

https://reviewboard.mozilla.org/r/87904/#review87008

::: toolkit/content/tests/widgets/test_videocontrols_iframe_fullscreen.html:43
(Diff revision 1)
> +    })).then(() => new Promise(resolve => {
> +      const videoControl = domUtils.getChildrenForNode(video, true)[1];
> +      const controlBar = video.ownerDocument.getAnonymousElementByAttribute(
> +        videoControl, "class", "controlBar");
> +
> +      is(controlBar.getAttribute("fullscreen-unavailable") == "true", !available);

is() has a third argument which is a text explanation of what you're verifying here, please add "The controlbar should have an attribute marking whether fullscreen is available that corresponds to if the iframe has the allowfullscreen attribute."

Also, can you file a follow-up bug to change the attribute name to "fullscreen-available" and then reverse all of this logic? We should make sure that attributes and variable names of booleans don't include a negation in them.

Comment 3

[Ray Lin[:ralin]]

Comment on attachment 8803764 [details]
Bug 1312324 - Add test to confirm fullscreen availability when video in an iframe.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87904/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b996ae995fe
Add test to confirm fullscreen availability when video in an iframe. r=jaws

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1b996ae995fe