New failures in interfaces.worker.js after updating web-platform-tests to new revision in Bug 1291312

RESOLVED FIXED in Firefox 52

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bevis, Assigned: bevis)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Updated

2 years ago
Blocks: 1178829
Looks like some [Exposed] attributes should be added to interfaces.idl.
(Assignee)

Comment 2

2 years ago
(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #1)
> Looks like some [Exposed] attributes should be added to interfaces.idl.

Yap, this is tested by idlharness.js in WPT now:
https://github.com/w3c/testharness.js/commit/acb6efbbaf5c1d32cd2049ecf830819d9a03f525

I am writing a patch to fix this. :)
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

2 years ago
(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #1)
> Looks like some [Exposed] attributes should be added to interfaces.idl.

In addition, [Exposed] has to be added for the interfaces added by idlArray.add_untested_idls as well.
(Assignee)

Updated

2 years ago
Blocks: 1306181
(Assignee)

Comment 4

2 years ago
Created attachment 8804540 [details] [diff] [review]
(v1) Patch: Add 'Exposed' attribute to pass the test criteria of the idlharness.js in WPT.

This was found while fixing bug 1306181.
The [Exposed] attribute is now taken into consideration in idleharness.js of WPT after this commit:
https://github.com/w3c/testharness.js/commit/acb6efbbaf5c1d32cd2049ecf830819d9a03f525
So we have to add this attribute accordingly in /IndexedDB/interfaces.idl to fix the failure.

Hi Ben,

May I have your review for this quick fix?

Thanks!

The treeherder result for reference:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b380e60982ec
Attachment #8804540 - Flags: review?(bkelly)
Attachment #8804540 - Flags: review?(bkelly) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7020b2be1285
Add 'Exposed' attribute to pass the test criteria of the idlharness.js in WPT. r=bkelly
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7020b2be1285
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.