Closed Bug 1312330 Opened 4 years ago Closed 4 years ago

New failures in interfaces.worker.js after updating web-platform-tests to new revision in Bug 1291312

Categories

(Core :: Storage: IndexedDB, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: bevis, Assigned: bevis)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Blocks: 1178829
Looks like some [Exposed] attributes should be added to interfaces.idl.
(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #1)
> Looks like some [Exposed] attributes should be added to interfaces.idl.

Yap, this is tested by idlharness.js in WPT now:
https://github.com/w3c/testharness.js/commit/acb6efbbaf5c1d32cd2049ecf830819d9a03f525

I am writing a patch to fix this. :)
Status: NEW → ASSIGNED
(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #1)
> Looks like some [Exposed] attributes should be added to interfaces.idl.

In addition, [Exposed] has to be added for the interfaces added by idlArray.add_untested_idls as well.
Blocks: 1306181
This was found while fixing bug 1306181.
The [Exposed] attribute is now taken into consideration in idleharness.js of WPT after this commit:
https://github.com/w3c/testharness.js/commit/acb6efbbaf5c1d32cd2049ecf830819d9a03f525
So we have to add this attribute accordingly in /IndexedDB/interfaces.idl to fix the failure.

Hi Ben,

May I have your review for this quick fix?

Thanks!

The treeherder result for reference:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b380e60982ec
Attachment #8804540 - Flags: review?(bkelly)
Attachment #8804540 - Flags: review?(bkelly) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7020b2be1285
Add 'Exposed' attribute to pass the test criteria of the idlharness.js in WPT. r=bkelly
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7020b2be1285
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.