1312330 - New failures in interfaces.worker.js after updating web-platform-tests to new revision in Bug 1291312

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect, P3)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

Check new failures added in https://hg.mozilla.org/mozilla-central/diff/9c3ff4fe0ebb/testing/web-platform/meta/IndexedDB/interfaces.worker.js.ini

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Looks like some [Exposed] attributes should be added to interfaces.idl.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #1)
> Looks like some [Exposed] attributes should be added to interfaces.idl.

Yap, this is tested by idlharness.js in WPT now:
https://github.com/w3c/testharness.js/commit/acb6efbbaf5c1d32cd2049ecf830819d9a03f525

I am writing a patch to fix this. :)

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #1)
> Looks like some [Exposed] attributes should be added to interfaces.idl.

In addition, [Exposed] has to be added for the interfaces added by idlArray.add_untested_idls as well.

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Patch: Add 'Exposed' attribute to pass the test criteria of the idlharness.js in WPT.

This was found while fixing bug 1306181.
The [Exposed] attribute is now taken into consideration in idleharness.js of WPT after this commit:
https://github.com/w3c/testharness.js/commit/acb6efbbaf5c1d32cd2049ecf830819d9a03f525
So we have to add this attribute accordingly in /IndexedDB/interfaces.idl to fix the failure.

Hi Ben,

May I have your review for this quick fix?

Thanks!

The treeherder result for reference:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b380e60982ec

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7020b2be1285
Add 'Exposed' attribute to pass the test criteria of the idlharness.js in WPT. r=bkelly

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7020b2be1285