Closed
Bug 1312331
Opened 9 years ago
Closed 9 years ago
inIDOMUtils.getCSSStyleRules should not repeatedly use insertElementAt(0) to produce a reversed array
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
|
1.24 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
We should do something better than repeatedly inserting an element at index 0 to build up the array of rules in inIDOMUtils.getCSSStyleRules.
|
Assignee | |
Comment 1•9 years ago
|
||
Noticed this when reviewing bug 1311191.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8803810 -
Attachment is patch: true
|
||
Updated•9 years ago
|
Attachment #8803810 -
Flags: review?(erahm) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8394f9b7b9e5
Build up list of applicable rules in reverse to avoid quadratic time array manipulations. r=erahm
Keywords: checkin-needed
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•