Closed Bug 1312331 Opened 8 years ago Closed 8 years ago

inIDOMUtils.getCSSStyleRules should not repeatedly use insertElementAt(0) to produce a reversed array

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

patch
1.24 KB, patch
erahm
: review+
Details | Diff | Splinter Review 
We should do something better than repeatedly inserting an element at index 0 to build up the array of rules in inIDOMUtils.getCSSStyleRules.
Attached patch patch — — Splinter Review 
Noticed this when reviewing bug 1311191.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8803810 - Flags: review?(erahm)
Depends on: 1311191
Attachment #8803810 - Attachment is patch: true
Attachment #8803810 - Flags: review?(erahm) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8394f9b7b9e5
Build up list of applicable rules in reverse to avoid quadratic time array manipulations. r=erahm
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8394f9b7b9e5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: