1312420 - Default weekly report in update orphaning dashboard is broken

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P4)

Description

[Stephen A Pohl [:spohl]]

Noticed this morning that the default selection in the update orphaning dashboard fails to fetch the right .json file. Somehow, [1] is now performing a mathematical addition of year, month and day before being treated as a string, resulting in a string of "2038.json" for the date of 2016-10-12. Previously, year, month and day were treated as strings and resulted in a string of "20161012.json". It might be as simple as changing this line to:

> var lastWedDataFile = "" + year + month + date + ".json";

or

> var lastWedDataFile = year + "" + month + "" + date + ".json";

but I haven't tested it.

[1] https://github.com/mozilla/telemetry-dashboard/blob/221d4b42f6e79dac7cc134e0011a15d6fbaa239d/update-orphaning/index.html#L135

Comment 1

[Molly Howell (she/her) (no longer active)]

https://github.com/mozilla/telemetry-dashboard/pull/253

Comment 2

[Molly Howell (she/her) (no longer active)]

Above PR has been merged.