1312440 - Remove the mPairedBracketType field from nsCharProps2 when ENABLE_INTL_API is set

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Jonathan Kew [:jfkthame]]

This field is unused when we have ICU available, so we should remove it from the struct.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Remove (unused) paired bracket data from our Unicode property tables when ICU is available

Looks like this was simply a mistake in bug 724538; this field need never have been included in the short version of the struct.

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8803905 [details] [diff] [review]
Remove (unused) paired bracket data from our Unicode property tables when ICU is available

Can you just remove mPairedBracketType instead of replacing it with a dummy field?

Comment 3

[Jonathan Kew [:jfkthame]]

Yes, we could do that. I'd like to keep it explicit that we have spare bits here, so we don't forget about them if we ever want to add some other flag, but we could just have a comment rather than an actual field.

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Remove (unused) paired bracket data from our Unicode property tables when ICU is available

Comment 5

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee1133c34b71c1257efbd561382156c75b2d21b6
Bug 1312440 - Remove (unused) paired bracket data from our Unicode property tables when ICU is available. r=emk

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ee1133c34b71