Add OnyxClient/WebMetadataKit Carthage projects to Firefox project using --use-submodules

RESOLVED INVALID

Status

()

P3
normal
RESOLVED INVALID
2 years ago
a year ago

People

(Reporter: sleroux, Unassigned)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios+)

Details

(Reporter)

Description

2 years ago
Having these two libraries moved out of the mainline application makes it more difficult to add modifications to them without having to go through the hassle of making a new release or having another copy of the framework to link locally that has the changes. Carthage has a solution to this where dependencies can be added as submodules to the project so that any changes to the libraries can be commit and pushed upstream. Unfortunately, this flag is used at the point of bootstrapping and is an all-or-nothing option right now. You're unable to selectively choose which dependencies you want to make submodules. Probably not that big of an issue since we won't be touch non-Mozilla dependencies anyways but is something to consider.
tracking-fxios: ? → +
Priority: -- → P3
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.