1312464 - Upgrade to django-ratelimit 1.0.1

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

We currently use 0.6.0.

One important change is that the current django-ratelimit we use uses
`cache.set(key, 1, time); cache.incr(key)` but if memcache has disappeared or something (which isn't unrealistic when distributed webheads and non-local memcacheds) you get a ValueError. 

In upgraded django-ratelimit it does::

 cache.set(key, 1, time)
 ...
 try:
    cache.incr(key)
 except ValueError:
    cache.set(key, 1, time)

Comment 1

[Peter Bengtsson [:peterbe]]

This is the change we want:
https://github.com/jsocol/django-ratelimit/commit/fa3f0afddc81f895705e3737a7b6adad3cec5fc2#diff-7a8901a0b952ff8d96cd3a44e4341f13R158

Comment 2

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3550

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/5f2f6bd4b4edb0f7c6be45d85f22b95ea86a680e
fixes bug 1312464 - Upgrade to django-ratelimit 1.0.1 (#3550)