Baldr: don't partially import functions

RESOLVED FIXED in Firefox 52

Status

()

Core
JavaScript Engine: JIT
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bbouvier, Assigned: bbouvier)

Tracking

Trunk
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Created attachment 8803955 [details] [diff] [review]
partial.patch

The spec test suite unveiled an issue in our implementation: we can have situations where we import a table, partially assign elements to it, then abort, leaving the table partially initialized.
Attachment #8803955 - Flags: review?(luke)
Comment on attachment 8803955 [details] [diff] [review]
partial.patch

Review of attachment 8803955 [details] [diff] [review]:
-----------------------------------------------------------------

Oh hah, this is another case where I filed the PR (https://github.com/WebAssembly/design/pull/780), got distracted while waiting for lgtm, and then forgot to write the patch.  Thanks!
Attachment #8803955 - Flags: review?(luke) → review+

Comment 2

a year ago
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc5faef03008
Check that functions assigned to tables are wasm functions earlier before assigning them; r=luke

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dc5faef03008
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.