1312516 - ASAN Taskcluster runs missing mochitest-a11y

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Ryan VanderMeulen [:RyanVM]]

I noticed today while working on bug 1305124 that ASAN is missing some mochitest suites that I'd expect it to be running. I'm wondering if it was intentional or just an oversight during the big TC refactoring work.

I've already confirmed on Try that mochitest-a11y works fine on ASAN. I haven't looked at the others yet, but I at least wanted to get this bug filed to track it.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/desktop-test/test-sets.yml#39

Looks intentional.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Yeah, I found that list. I have no idea how the list of test suites was derived, however. That's the intentional I was referring to.

Comment 3

[Geoff Brown [:gbrown]]

So, looking back further, I think I'm involved with bug 1281501. My intention there was to run all of the tests which were - at the time - running on buildbot Linux 64 ASAN. If I didn't see a job running on buildbot, I did not try to run it on taskcluster. I am 90% sure that was the case with mochitest-a11y.

Comment 4

[Geoff Brown [:gbrown]]

On the other hand, I see buildbot a11y running on mozilla-beta, in mochitest-other...so I guess it was missed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

I'm generally of the opinion that they should be running by default unless there's a strong argument for not doing so. ASAN in particular is high-value due to its ability to catch sec issues and leaks that other platforms/flavors can't.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Looks like a11y is in fact the only missing mochitest suite (and Aurora is also affected). I see mochitest-chrome running across all the trees, though.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Attachment: run mochitest-a11y on ASAN

As mentioned before, I've already confirmed that this runs green on Try.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a441a6cdce3
Run mochitest-a11y on ASAN. r=dustin

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8a441a6cdce3