1312538 - Improve layout for email submission with errors

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[John Whitlock [:jwhitlock]]

Attachment: Screenshot 2016-10-24 15.13.28.png

On https://www.mozilla.org/en-US/newsletter/recovery/, errors cause the layout of the email submission form to break, especially on narrow screens.  The error text should be places so that it does not break the layout.

Comment 1

[Paul [:pmac] McLanahan]

Alex, could this be related to bug 1276217?

Comment 2

[Alex Gibson [:agibson]]

It looks like this is a bit of a mixture of errors. The error field is obscured because both the intro text and form field container are floated in CSS, so the error-list likely needs a clear fix of some sort. Probably been this way for some time. The email field overlapping the button at medium screen widths probably is related to bug 1276217.

I'll see if I can take a look at this today.

Comment 3

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a4ee14737fb27864b6e3165bf12939292fc4a97e
[fix bug 1312538] Improve layout for email submission with errors

https://github.com/mozilla/bedrock/commit/35fd94b76eeb58a024e90703a154d809eb5e1ce5
Merge pull request #4434 from alexgibson/bug-1312538-email-form-error-layout

[fix bug 1312538] Improve layout for email submission with errors