Use cPickle instead of json to serialize the tests database

RESOLVED FIXED in Firefox 52

Status

defect
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: chmanchester, Assigned: chmanchester)

Tracking

unspecified
mozilla52
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

This is faster, particularly on Windows. I have a patch for this, but it depends on details of bug 1312520 that haven't seen review yet.

Comment 2

3 years ago
mozreview-review
Comment on attachment 8804432 [details]
Bug 1312574 - Use cPickle instead of json to serialize the build system's tests database.

https://reviewboard.mozilla.org/r/88400/#review88106

Looks good.

Next time, please write a descriptive commit message describing the improved performance. As a reviewer, it helps me weigh things like "is this change worth it."
Attachment #8804432 - Flags: review?(gps) → review+

Comment 3

3 years ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12987daa4d68
Use cPickle instead of json to serialize the build system's tests database. r=gps

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/12987daa4d68
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.