Duplicate autoclassification information across TextLogError and FailureLine

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jgraham, Assigned: jgraham)

Tracking

(Blocks: 1 bug)

Details

Attachments

(3 attachments)

(Assignee)

Description

a year ago
As a prelude to going via TextLogError for all autoclassification and error processing. Eventually the columns will be removed from FailureLine, but that requires later steps so that code doesn't depend on those values any more.
Created attachment 8804065 [details] [review]
[treeherder] mozilla:classification_text_log_error > mozilla:master
(Assignee)

Updated

a year ago
Attachment #8804065 - Flags: review?(wlachance)

Updated

a year ago
Assignee: nobody → james
Attachment #8804065 - Flags: review?(wlachance)
(Assignee)

Updated

a year ago
Attachment #8804065 - Flags: review?(wlachance)
Comment on attachment 8804065 [details] [review]
[treeherder] mozilla:classification_text_log_error > mozilla:master

Meant to r+ this earlier, sorry.
Attachment #8804065 - Flags: review?(wlachance) → review+

Comment 3

a year ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4da51949a0ad0456d2a638e467e1c7c4ca29f37c
Bug 1312575 - Duplicate autoclassification information across TextLogError and FailureLine (#1950)

This adds a FailureLine foreign key to TextLogError and duplicates the
best_classification and best_is_verified columns. Classifications are
still set on FailureLine and copied to the corresponding column on
TextLogError.

This is a prelude to future work which will remove classifications from
FailureLine altogether, so that all autoclassification data can be
retrieved from TextLogError.
Created attachment 8813674 [details] [review]
[treeherder] mozilla:revert-1950-classification_text_log_error > mozilla:master

Comment 5

a year ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0e8f0572cd6fedc457d12b255188c2d2051fef69
Revert "Bug 1312575 - Duplicate autoclassification information across TextLogError and FailureLine" (#1996)
(Assignee)

Updated

a year ago
Blocks: 1321787
(Assignee)

Updated

a year ago
Blocks: 1321798
(Assignee)

Updated

a year ago
Blocks: 1321802
Created attachment 8838049 [details] [review]
[treeherder] mozilla:autoclassify_duplicate > mozilla:master
(Assignee)

Updated

a year ago
Attachment #8838049 - Flags: review?(wlachance)
Attachment #8838049 - Flags: review?(emorley)

Updated

a year ago
Attachment #8838049 - Flags: review?(emorley) → feedback+
Comment on attachment 8838049 [details] [review]
[treeherder] mozilla:autoclassify_duplicate > mozilla:master

I think I'd like to see the modifications I mentioned in the PR before this goes in, hope it doesn't take too much extra time...
Attachment #8838049 - Flags: review?(wlachance)
(Assignee)

Updated

a year ago
Attachment #8838049 - Flags: review?(wlachance)
Attachment #8838049 - Flags: review?(emorley)
Comment on attachment 8838049 [details] [review]
[treeherder] mozilla:autoclassify_duplicate > mozilla:master

There are a few changes I'd like to see before this lands.
Attachment #8838049 - Flags: review?(wlachance)
(Assignee)

Updated

a year ago
Attachment #8838049 - Flags: review?(wlachance)
Attachment #8838049 - Flags: review?(wlachance) → review+
Comment on attachment 8838049 [details] [review]
[treeherder] mozilla:autoclassify_duplicate > mozilla:master

r+ with the review comment addressed :-)
Attachment #8838049 - Flags: review?(emorley) → review+

Comment 10

a year ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/184ba384f0c132f01470ef39c189fc14c66d0cc4
Bug 1312575 - Duplicate autoclassification information across TextLogError and FailureLine (#2178)

This adds a FailureLine foreign key to TextLogError and duplicates the
best_classification and best_is_verified columns. Classifications are
still set on FailureLine and copied to the corresponding column on
TextLogError.

This is a prelude to future work which will remove classifications from
FailureLine altogether, so that all autoclassification data can be
retrieved from TextLogError.

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED

Updated

a year ago
Depends on: 1345220

Updated

a year ago
Depends on: 1345918
You need to log in before you can comment on or make changes to this bug.