Fix gfxPref syncing stale prefs to GPU process

RESOLVED FIXED in Firefox 52

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rhunt, Assigned: rhunt)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Don't use the cached value for syncing to the GPU process when we observer a pref change, because the cached value may not have been updated yet. This can cause the prefs in the GPU process to get out of sync.
(Assignee)

Comment 1

2 years ago
Created attachment 8804105 [details] [diff] [review]
stale-pref.patch
Attachment #8804105 - Flags: review?(dvander)
Attachment #8804105 - Flags: review?(dvander) → review+

Comment 2

2 years ago
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95e09163347a
Use live pref values when syncing gfxPrefs to the GPU process r=dvander

Comment 3

2 years ago
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1f1a53aac73
Backed out changeset 95e09163347a for build bustage. r=backout on a CLOSED TREE
(Assignee)

Comment 4

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=55fd19db6b57

Fix for bustage. There should be no behavioral differences except for in the gpu process which is not enabled yet.

Comment 5

2 years ago
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28986ba05618
Use live pref values when syncing gfxPrefs to the GPU process r=dvander

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/28986ba05618
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.