131264 - [e-mail] need cvs check in right

Status: VERIFIED FIXED

(mozilla.org :: Repository Account Requests, task)

Description

[Frank Tang]

I am not sure [e-mail] is ready for this or not. But log a request for
him now.
pete, please put down the bug number of the patch you submit in this bug.

Comment 1

[Frank Tang]

[e-mail] wrote 
>Pete has contributed 5 patches to trunk( 3 checked in, 1 got r=, 1 is waiting
for r=)

Comment 2

[Pete Zha]

1 #122726 checked in (Unable to enumerate the form elements by using for/in.)
2 #121726 checked in (The order of the form elements changed when the name
property of the form element is setted by using JavaScript.)
3 #129533 checked in (|Cannot use const char* to initialize char*| bustage)
4 #52815 need sr= (remove 3rd tab in an input[type="file"] form element tab
cycle order)
5 #70478 need work (The "quote original message" option is missing when creating
a reply or new message)

Comment 3

[Johnny Stenback (:jst)]

sr=jst for giving Pete CVS access.

Comment 4

[Pete Zha]

Bug 52815 has been checked in. (r=bryner, sr=attinasi, a=asa)

Comment 5

[Aaron Leventhal]

I will vouch for Pete.

Comment 6

[kill this account]

Pete: have you worked on IDL or XPCOM?

http://www.mozilla.org/hacking/getting-cvs-write-access.html

> a nominee's code ought demonstrate that s/he has encountered complex topics 
> (for example, IDL interfaces and XPCOM reference management) and handled them 
> well. 

Comment 7

[Pete Zha]

Brian, yeah, I have. In bug 70478 I add and modify some method in IDL and
implement them in cpp. And in bug 122726, lots of place use Interface and XPCOM
reference management.

Comment 8

[Pete Zha]

New working list.
1  bug 122726 (Unable to enumerate the form elements by using for/in.)
2  bug 121726 (The order of the form elements changed when the name
property of the form element is setted by using JavaScript.)
3  bug 129533 (|Cannot use const char* to initialize char*| bustage)
4  bug 52815 (remove 3rd tab in an input[type="file"] form element tab
cycle order)
5  bug 70478 (The "quote original message" option is missing when creating
a reply or new message)
6  bug 83496 (Need mechanism that allows us to figure out how focus was gained)
7  bug 28583 (Focusing text widget (except on click) should select widget contents.)
8  bug 131139 (Right-clicking or dragging a link clears selection)
9  bug 132099 (can't type in link text)
10 bug 132557 (input[type="file"] button should show tab focus)
11 bug 44813 (new bookmarks should be selected after you create them)

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

sr=roc+moz

Comment 10

[Pete Zha]

roc-moz: Thank you very much! :-)

Comment 11

[Pete Zha]

blizzard:I need your comments. Thanks :-)

Comment 12

[Pete Zha]

12 bug 125107 (File Bookmark: creating a new folder should select it)

Comment 13

[Pete Zha]

Fix for bug 44813 has been checked in

Comment 14

[Brendan Eich [:brendan]]

sr=[e-mail] for Pete's CVS commit access -- I thought chofmann
already recorded my sr= here, but I don't see it.

Marcia, I'm third after jst and roc, so please enable the account once you have
Pete's signed, faxed form.  Thanks,

/be

Comment 15

[Pete Zha]

brendan, Thanks a lot!

Comment 16

[Pete Zha]

Marcia,
I have sent the Contributor Form to you via fax, please check it.
And I will mail the original form via postal mail to you soon. 
Thanks a lot. 

Pete

Comment 17

[Marcia Knous [:marcia]]

form received. account activated. 

Comment 18

[Pete Zha]

Verify fixed! Thanks all!