Closed
Bug 1312642
Opened 6 years ago
Closed 6 years ago
PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | unaffected |
| firefox51 | --- | fixed |
| firefox52 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
References
Details
Attachments
(2 files)
|
58 bytes,
text/x-review-board-request
|
lina
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
|
930 bytes,
patch
|
Details | Diff | Splinter Review |
Otherwise our onItemMove listener doesn't ignore the move.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → markh
Status: NEW → ASSIGNED
status-firefox50:
--- → unaffected
status-firefox51:
--- → affected
status-firefox52:
--- → affected
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8804121 [details] Bug 1312642 - PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder. https://reviewboard.mozilla.org/r/88246/#review87322
Attachment #8804121 -
Flags: review?(kcambridge) → review+
|
|
||
Updated•6 years ago
|
Pushed by mhammond@skippinet.com.au: https://hg.mozilla.org/integration/autoland/rev/49a1469f39a3 PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder. r=kitcambridge
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8804121 [details] Bug 1312642 - PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder. Approval Request Comment [Feature/regressing bug #]: Bug 1299338. [User impact if declined]: Unnecessary bookmark syncs when syncing folders from another device. [Describe test coverage new/current, TreeHerder]: Test in bug 1312857. [Risks and why]: Low risk. One-line change that adds an optional argument. [String/UUID change made/needed]: None.
Attachment #8804121 -
Flags: approval-mozilla-aurora?
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/49a1469f39a3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Comment 6•6 years ago
|
||
Comment on attachment 8804121 [details] Bug 1312642 - PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder. Fix bookmark syncing issue. Take it in 51 aurora.
Attachment #8804121 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 7•6 years ago
|
||
has problems uplifting to aurora grafting 371544:49a1469f39a3 "Bug 1312642 - PlacesSyncUtils should pass SOURCE_SYNC to PlacesUtils.bookmarks.reorder. r=kitcambridge" merging toolkit/components/places/PlacesSyncUtils.jsm warning: conflicts while merging toolkit/components/places/PlacesSyncUtils.jsm! (edit, then use 'hg resolve --mark') abort: unresolved conflicts, can't continue (use 'hg resolve' and 'hg graft --continue') Tomcats-MacBook-Pro-2:mozilla-central Tomcat$
Flags: needinfo?(markh)
|
|
||
Comment 8•6 years ago
|
||
Rebased patch for Aurora. This should fix xpcshell bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=4001369&repo=mozilla-aurora#L2199.
|
|
||
Updated•6 years ago
|
Flags: needinfo?(markh)
You need to log in
before you can comment on or make changes to this bug.
Description
•