Closed Bug 1312680 Opened 5 years ago Closed 5 years ago

Add test: require-sri-for should block style loads (import, url)

Categories

(Core :: DOM: Security, defect, P3)

Product:
Core
Component:
DOM: Security
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: freddy, Assigned: freddy)

References

Details

(Whiteboard: [domsecurity-backlog1])

Attachments

(1 file, 1 obsolete file)

0001-Bug-1312680-Test-that-require-sri-for-blocks-style-l.patch
5.62 KB, patch
freddy
: review+
Details | Diff | Splinter Review 
No description provided.
Summary: require-sri-for should block style loads (import, url) → Add test: require-sri-for should block style loads (import, url)
Attachment #8804637 - Flags: review?(francois)
Priority: -- → P3
Whiteboard: [domsecurity-backlog1]
Comment on attachment 8804637 [details]
Bug 1312680: Test that require-sri-for blocks style loads via @import

https://reviewboard.mozilla.org/r/88552/#review89426

::: dom/security/test/sri/mochitest.ini:57
(Diff revision 1)
>  [test_style_crossdomain.html]
>  [test_style_sameorigin.html]
>  [test_require-sri-for_csp_directive.html]
>  [test_require-sri-for_csp_directive_disabled.html]
>  [test_bug_1271796.html]
> +[test_bug_1312680.html]

nit: I personnally prefer to see descriptive names here (like `test_require-sri-for-csp_directive.html`).

::: dom/security/test/sri/test_bug_1312680.html:13
(Diff revision 1)
> +  <title>Test for SRI require-sri-for CSP directive</title>
> +  <script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
> +  <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
> +</head>
> +<body>
> +<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1312680">Mozilla Bug 1312680</a><br>

nit: A more appropriate bug number would be the one where the actual bug was reported and fixed.
Attachment #8804637 - Flags: review?(francois) → review+
rebased and nits applied. carrying over r+
Assignee: nobody → fbraun
Attachment #8804637 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8807091 - Flags: review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/970a2877f184
Test that require-sri-for blocks style loads via @import r=francois
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/970a2877f184
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.