1312686 - Link "default browser" setting to app info screen on Android 7+

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: default_browser.png

Android 6.0 introduced a default browser setting, but it was buried in the device's settings. Now with Android 7 or 7.1 this setting is linked from the app info screen (see attached screenshots).

Instead of linking "Make default browser" to a SUMO article we could link to the app info screen directly.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Sebastian Kaspari (:sebastian) from comment #0)
> Created attachment 8804185 [details]
> default_browser.png
> Instead of linking "Make default browser" to a SUMO article we could link to
> the app info screen directly.

YES.

Comment 2

[Tomislav Jurin]

As suggested by Sebastian, I would like totry fix this.

Thanks

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

It's yours! Thank you. :)

If you have any questions then just flag me. For UX related questions just flag antlam.

Comment 4

[Tomislav Jurin]

Hi Sebastian, I would need some guidance for starting.
TBH I have no idea where to start looking.

You mentioned in your 0# post:

"Instead of linking "Make default browser" to a SUMO article we could link to the app info screen directly."

Any ideas how can this be done ? Where to look in mozilla-central ?

Thanks a lot.

Comment 5

[4a-support]

if(Build.VERSION.SDK_INT >= 24) {
   Intent iChangeDefaultApps = new Intent(Settings.ACTION_MANAGE_DEFAULT_APPS_SETTINGS);
   startActivity(iChangeDefaultApps);
}

Note that, for downlevel versions, it's possible to at least programmatically clear the current default, even if you can't push the user to set a new one.

Comment 6

[Gautam Prajapati]

Hi Sebastian, I have successfully built the fennec project. I'd like to work on this issue as my starting point.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Gautam: Great! We'll assign the bug to you after you have upload the first version of your patch. Let me know (here or on IRC in #mobile) if you need help!

Comment 8

[Gautam Prajapati]

Hi Sebastian, for lower API levels than 24, I don't think we can clear defaults of all other apps programmatically. We can clear the defaults of our application though, with this:
  
getPackageManager().clearPackagePreferredActivities(getPackageName());
 
I'd appreciate your inputs here. Should I direct the user to App info screen for lower API levels?

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

For lower API levels just keep the code as-is: Open a support web page that explains how this can be done manually.

Comment 10

[Gautam Prajapati]

Attachment: Bug 1312686 - Link "default browser" setting to app info screen on Android 7+;

Added support for changing default browser by opening settings screen in API Levels >=24.

Review commit: https://reviewboard.mozilla.org/r/112116/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112116/

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8836789 [details]
Bug 1312686 - Link "default browser" setting to app info screen on Android 7+;

https://reviewboard.mozilla.org/r/112116/#review113820

::: mobile/android/base/java/org/mozilla/gecko/preferences/LinkPreference.java:37
(Diff revision 1)
> +    /**
> +     * Open Default apps screen of Settings for API Levels>=24. Support URL will open for lower API levels
> +     */
>      @Override
>      protected void onClick() {
> +        if (Build.VERSION.SDK_INT >= 24) {

Please use (or add) a constant for this to AppConstants.

::: mobile/android/base/java/org/mozilla/gecko/preferences/LinkPreference.java:40
(Diff revision 1)
> +        }
> +        else {

nit: style:
> } else {

Comment 12

[Gautam Prajapati]

Comment on attachment 8836789 [details]
Bug 1312686 - Link "default browser" setting to app info screen on Android 7+;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112116/diff/1-2/

Comment 13

[Gautam Prajapati]

Comment on attachment 8836789 [details]
Bug 1312686 - Link "default browser" setting to app info screen on Android 7+;

Hi Sebastian, thanks for reviewing, I have updated the commit.

Comment 14

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8836789 [details]
Bug 1312686 - Link "default browser" setting to app info screen on Android 7+;

https://reviewboard.mozilla.org/r/112116/#review114060

Thank you! This is looking good.

I pushed your patch to the try server (to run all our automated tests):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=305507310f04

If this was successfull then we can land the patch. You can just edit the bug and add the "checkin-needed" keyword to it. A tree sherrif will take care of landing your patch after that.

Comment 15

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sebastian Kaspari (:sebastian) from comment #14)
> If this was successfull then we can land the patch. You can just edit the
> bug and add the "checkin-needed" keyword to it. A tree sherrif will take
> care of landing your patch after that.

Oh, and please go to Mozreview and mark the review comments as "Fixed" now that you pushed a new patch. Otherwise this patch can't be landed. :)

Comment 16

[Gautam Prajapati]

> Oh, and please go to Mozreview and mark the review comments as "Fixed" now that you pushed a new patch. 
> Otherwise this patch can't be landed. :)

Thanks, Sebastian! I have marked the review comments as 'Fixed'. 
By the way, it doesn't matter if this issue is not assigned to me, right? Can we close this issue as fixed?

Comment 17

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Gautam Prajapati from comment #16)
> By the way, it doesn't matter if this issue is not assigned to me, right?

I just assigned it to you.

(In reply to Gautam Prajapati from comment #16)
> Can we close this issue as fixed?

It will be closed automatically as soon as the patch has been merged to mozilla-central. All tests have been passed successfully. You can add the checkin-needed keyword to the bug now.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/742e4f33e3d6
Link "default browser" setting to app info screen on Android 7+; r=sebastian

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/742e4f33e3d6

Comment 20

[Sorina Florean [:sflorean]]

Verified as fixed in build 54.0a1 (2017-02-20);
Device: Nexus 9 (Android 7.1.1).

'Make default browser' from Nightly Settings page goes to app info from Android settings.