1312755 - sizemode attribute is "normal" if firefox is started maximized with SW_SHOWMAXIMIZED and sizemode="normal" in xulstore.json

Status: UNCONFIRMED

(Core :: Widget: Win32, defect, P3)

Description

[uFFFD]

Attachment: nightly 52.0a1 on windows xp

Steps to reproduce:

1. start firefox

2. ensure window state of browser's main-window is normal (restored, not maximized)
   i.e. xulstore.json["chrome://browser/content/browser.xul"]["main-window"]["sizemode"] = "normal"

3. exit firefox completely

4. start firefox with SW_SHOWMAXIMIZED:

   * run `start /max firefox.exe` in command prompt
   * or create a shortcut to firefox's binary first
     next, open shortcut's properties window and set "Run"to "Maximized" in "Shortcut" tab
     then use this shortcut to start firefox
   * or pass a STARTUPINFO struct with dwFlags |= STARTF_USESHOWWINDOW and
     wShowWindow = SW_SHOWMAXIMIZED to CreateProcess function to start firefox

5. run following code snippet in browser console (ctrl + shift + j):

    nbwin = Services.wm.getMostRecentWindow("navigator:browser");
    console.log("windowState: " + nbwin.windowState);
    console.log("sizemode: " + nbwin.document.documentElement.getAttribute("sizemode"));



Actual result:

browser console shows:

    windowState: 1 // means window.STATE_MAXIMIZED
    sizemode: normal

additionally, the appearances of tabs and menubar (if not hidden) are messed up
buttons in title bar are "Minimize", "Maximize" and "Close" if browser.tabs.drawInTitlebar is true

moreover, if browser's main window regains focus after loses it once, e.g. switch focus to browser console and then switch it back to main window, sizemode will be set to "maximized" and partially fix appearances, but there will still be some appearance issues left if browser.tabs.drawInTitlebar is true



Expected result:

browser console shows:

    windowState: 1 // means window.STATE_MAXIMIZED
    sizemode: maximized



this issue affects firefox 4.0 ~ 52.0a1 (today's nightly, build id 20161025030205)
screenshots are taken on windows xp
it's been confirmed on windows 7 and windows 10 as well