Closed
Bug 1312764
Opened 10 years ago
Closed 10 years ago
Backout the rounding changes from cubeb_wasapi.cpp from aurora
Categories
(Core :: Audio/Video: cubeb, defect, P1)
Core
Audio/Video: cubeb
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | unaffected |
| firefox51 | --- | fixed |
| firefox52 | --- | wontfix |
People
(Reporter: padenot, Assigned: padenot)
References
Details
Attachments
(1 file)
|
3.53 KB,
patch
|
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We're keeping duplex enabled on aurora, so instead of backing the whole uplift out, we're simply reverting one line.
We're simply applying a new patch to a revision of cubeb so it's clear what we're doing, instead of modifying cubeb in place, as noted by kinetik in https://bugzilla.mozilla.org/show_bug.cgi?id=1310206#c8.
| Assignee | ||
Updated•10 years ago
|
| Assignee | ||
Comment 1•10 years ago
|
||
We're keeping duplex enabled on aurora, so instead of backing the whole uplift
out, we're simply reverting one line.
| Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8804282 [details] [diff] [review]
Backout part of bug 1310206
Approval Request Comment
[Feature/regressing bug #]: 1310206
[User impact if declined]: some media in some configuration don't have sound
[Describe test coverage new/current, TreeHerder]: nothing new
[Risks and why]: no risk, was only present for a short while in aurora
[String/UUID change made/needed]: none
Attachment #8804282 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Rank: 15
Priority: -- → P1
Comment 3•10 years ago
|
||
Comment on attachment 8804282 [details] [diff] [review]
Backout part of bug 1310206
Let's take it so that people have sound, thanks.
Attachment #8804282 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 4•10 years ago
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox50:
--- → unaffected
status-firefox52:
--- → wontfix
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•