outputToString should return the string

VERIFIED FIXED in mozilla1.0

Status

()

Core
Editor
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: Akkana Peck, Assigned: Akkana Peck)

Tracking

Trunk
mozilla1.0
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
Currently the signature for outputToString looks like this:

  void outputToString(out AString outputString,
                      in AString formatType,
                      in unsigned long flags);

This is hard to use (you have to make a JS object, pass it through, then get the
.value after the return).

Let's change it to return the string, as part of the ongoing idl cleanup, i.e.

  AString outputToString(in AString formatType, in unsigned long flags);

Comment 1

16 years ago
Same for OutputToStream(), right?
(Assignee)

Comment 2

16 years ago
No, outputToStream doesn't return the stream at all; it takes a stream as input,
then outputs the characters on the stream, returning void.  So I'm assuming it
doesn't need fixing.
Status: NEW → ASSIGNED
Keywords: nsbeta1
Target Milestone: --- → mozilla1.0

Comment 3

16 years ago
Sorry, you're right. Are there any other 'out' params lurking?
(Assignee)

Comment 4

16 years ago
Created attachment 74805 [details] [diff] [review]
Change signature of outputToString everywhere

Strangely, we don't seem to have any JS users of this interface (at least, I
don't find any in the editor, and lxr doesn't find any).  This fixes all the
C++ references.  Seeking review.

Comment 5

16 years ago
Comment on attachment 74805 [details] [diff] [review]
Change signature of outputToString everywhere

r=jfrancis

Comment 6

16 years ago
Comment on attachment 74805 [details] [diff] [review]
Change signature of outputToString everywhere

sr=sfraser. Adding r= from jfrancis
Attachment #74805 - Flags: superreview+
Attachment #74805 - Flags: review+

Comment 7

16 years ago
Comment on attachment 74805 [details] [diff] [review]
Change signature of outputToString everywhere

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #74805 - Flags: approval+
(Assignee)

Comment 8

16 years ago
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 9

16 years ago
akkana, please verify...
(Assignee)

Comment 10

16 years ago
Verifying.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 11

16 years ago
Whoops!  Somehow this checkin didn't actually make it in.  I'm very confused
about what happened here.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 12

16 years ago
Let's try that again.  Fix is in.  I'll verify via lxr this time. :-)
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED

Comment 13

16 years ago
Akkana, give it another whirl....

Comment 14

16 years ago
verified; I saw that the idl change was checked in
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.