1312865 - WebGL 2 clearBufferfi does not work for clearing the contents of a depth-stencil texture in an FBO.

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Jukka Jylänki]

STR:

1. Visit http://clb.demon.fi/bugs/offscreen_fbo/fbo_test.htm
2. Visit http://clb.demon.fi/bugs/offscreen_fbo/fbo_test.htm?fbo

Expected:

The first URL renders a cube without FBOs. The second one is the same, but rendering is done to an offscreen depth-stencil-color FBO combination, which is finally blitted to screen. The two test cases should produce identical output.

Observed:

The second fbo-utilizing path does not produce correct output.

Comment 1

[Robert Goulet]

Thanks for writing this test case. This affects 49 all the way up to 52 afaik.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Dzmitry, can you take a look at this bug over the next few days?

Comment 3

[Dzmitry Malyshau [:kvark]]

On it

Comment 4

[Dzmitry Malyshau [:kvark]]

Attachment: webgl-notify.patch

Comment 5

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8820535 [details] [diff] [review]
webgl-notify.patch

Review of attachment 8820535 [details] [diff] [review]:
-----------------------------------------------------------------

Great catch. The full fix is a little trickier, since we have some state yet we need to juggle. (a la WebGLContext::Clear)

Given the time sensitivity here, I'm going to take this starting from this patch.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1312865 - ClearBuffer and similar funcs should mirror Clear's behavior. -

Review commit: https://reviewboard.mozilla.org/r/100082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100082/

Comment 7

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8820586 [details]
Bug 1312865 - ClearBuffer and similar funcs should mirror Clear's behavior. -

https://reviewboard.mozilla.org/r/100082/#review100560

LGTM

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/180e256b5793
ClearBuffer and similar funcs should mirror Clear's behavior. - r=daoshengmu

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/180e256b5793

Comment 10

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fa050cde19b9

Comment 11

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-beta/rev/03149282c791