1312903 - Land the missing bits in browser-sets.inc

Status: RESOLVED FIXED

(L20n :: General, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Somewhere during larch lifetime, we lost a couple of changes that landed on m-c and somehow didn't get merged into larch's browser-sets.inc which results in the bc4 failures.

The changes are:

 - https://hg.mozilla.org/mozilla-central/diff/2beb0d486fc6/browser/base/content/browser-sets.inc
 - https://hg.mozilla.org/mozilla-central/diff/b48d78377113/browser/base/content/browser-sets.inc

Both were multiple times landed, backed out and relanded, but I'm not sure how they ended up not being in larch now :(

It makes me worried about hg's automerge.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1312903 - Land the missing bits in browser-sets.inc;

Review commit: https://reviewboard.mozilla.org/r/88456/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88456/

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 8804510 [details]
Bug 1312903 - Land the missing bits in browser-sets.inc;

https://reviewboard.mozilla.org/r/88456/#review87614

Nice work, Zibi!  Thanks for finding these.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

https://hg.mozilla.org/projects/larch/rev/8e23fb23036b1d49ab9b39c5d79fbf12d4336a8b
Bug 1312903 - Land the missing bits in browser-sets.inc; r?stas