1312936 - Use ACString for nsITranserable.getAnyTransferData

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Makoto Kato [:m_kato]]

To reduce small allocation and clean up editor code...

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1312936 - Part 1. Use ACString for nsITranserable.getAnyTransferData.

Review commit: https://reviewboard.mozilla.org/r/88472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88472/

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1312936 - Part 2. Use nsAutoCString for nsITranserable.getAnyTransferData into editor.

Also, replace nsCRT::strcmp with EqualsLiteral.  nsCRT::strcmp is deprecated API.

Review commit: https://reviewboard.mozilla.org/r/88474/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88474/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8804537 [details]
Bug 1312936 - Part 1. Use ACString for nsITranserable.getAnyTransferData.

https://reviewboard.mozilla.org/r/88472/#review87548

::: widget/nsITransferable.idl:145
(Diff revision 1)
>      *
>      * @param  aFlavor (out parameter) the flavor of data that was retrieved
>      * @param  aData the data. Some variant of class in nsISupportsPrimitives.idl
>      * @param  aDataLen the length of the data
>      */
> -  void getAnyTransferData ( out string aFlavor, out nsISupports aData, out unsigned long aDataLen ) ;
> +  void getAnyTransferData ( out ACString aFlavor, out nsISupports aData,

I assume that only ASCII characters are available for Content-Type value. If no, we need to use AUTF8String.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8804538 [details]
Bug 1312936 - Part 2. Use nsAutoCString for nsITranserable.getAnyTransferData into editor.

https://reviewboard.mozilla.org/r/88474/#review87550

Excellent!

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

FYI: there are similar issues in other IDLs, sigh.
https://dxr.mozilla.org/mozilla-central/search?q=flavor+path%3Aidl&redirect=false

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 8804537 [details]
Bug 1312936 - Part 1. Use ACString for nsITranserable.getAnyTransferData.

https://reviewboard.mozilla.org/r/88472/#review87548

> I assume that only ASCII characters are available for Content-Type value. If no, we need to use AUTF8String.

This is ASCII only

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80687b4d7461
Part 1. Use ACString for nsITranserable.getAnyTransferData. r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/357f4f16be12
Part 2. Use nsAutoCString for nsITranserable.getAnyTransferData into editor. r=masayuki

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/80687b4d7461
https://hg.mozilla.org/mozilla-central/rev/357f4f16be12