1312975 - [DateTimeInput] Clear button in <input type="time"> is transparent

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Sebastian Zartner [:sebo]]

In bug 1310587 the background of the clear button of the time input was made transparent, which also made the X inside it transparent.

Though to make the button UI visibly independent of the input's background the X should be made opaque.

Sebastian

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

NI Visual designer for input.

Comment 2

[Helen Huang [:HHuang]]

Attachment: clear.svg

Thanks for the advice. I've updated the clear icon, the X of the clear button is white now.

Comment 3

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 4

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8804968 [details] [diff] [review]
patch, v1.

Review of attachment 8804968 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Mike, sorry for bothering you again about this. I'm updating the latest icon from Visual, could you help review this? Thanks.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8804968 [details] [diff] [review]
patch, v1.

Review of attachment 8804968 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks jjong!

::: toolkit/themes/shared/icons/input-clear.svg
@@ +6,5 @@
> +	.st0{fill:#858585;}
> +	.st1{fill:#FFFFFF;}
> +</style>
> +<circle id="Combined-Shape" class="st0" cx="6" cy="6" r="6"/>
> +<polygon id="Close_Button_-_Normal-path" class="st1" points="9,8.1 8.1,9 6,6.9 3.9,9 3,8.1 5.1,6 3,3.9 3.9,3 6,5.1 8.1,3 9,3.9 

Trailing whitespace. Does this need to be broken up over two lines?

Comment 6

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v2.

Thanks Mike, revised the file based on this guideline:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/SVG_Guidelines

Comment 7

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f38c0f2807e

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/691b2d09dd09
update reset button icon in datetime input field. r=mconley

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/691b2d09dd09

Comment 10

[Alfred Kayser]

Is the Adobe Illustrator required in Mozilla shipped code?

Comment 11

[Jessica Jong [:jessica] (inactive)]

(In reply to Alfred Kayser from comment #10)
> Is the Adobe Illustrator required in Mozilla shipped code?

Do you mean the comment "Generator: Adobe Illustrator 19.2.1.."? I removed it based on this guideline: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/SVG_Guidelines#Editor_metadata

Comment 12

[Alfred Kayser]

Yes, that's it. Thx!

Comment 13

[Sebastian Zartner [:sebo]]

Works for me. Thank you for the quick fix!

Sebastian